Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added operation_id for async APIs #997

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

manasmulay
Copy link

Add operation_id (UUID) in callback, as well as create, restore, upload and download APIs. This helps when parallel operations are enabled and callbacks are to be sent at only one endpoint.

Manas Mulay added 2 commits August 27, 2024 19:04
…e/{name}, backup/upload/{name}, backup/download/{name}

- Added operation_id to be sent in success and error callback
@manasmulay manasmulay marked this pull request as draft August 27, 2024 13:53
pkg/server/server.go Outdated Show resolved Hide resolved
@Slach
Copy link
Collaborator

Slach commented Aug 28, 2024

CI/CD failures are unrelated to your code, but related to your fork secrets settings, I will think how to fix it in main branch

@Slach Slach changed the base branch from master to v2.6 August 28, 2024 18:19
@Slach Slach added this to the 2.6.0 milestone Aug 28, 2024
@Slach Slach changed the base branch from v2.6 to master August 28, 2024 18:19
@Slach
Copy link
Collaborator

Slach commented Aug 28, 2024

could you run git pull origin master

@manasmulay
Copy link
Author

manasmulay commented Aug 29, 2024

Done. I will add support for operation_id in status API in a separate PR, will take me some time

@manasmulay manasmulay closed this Aug 29, 2024
@manasmulay
Copy link
Author

I have accidentally closed this PR, adding this comment to reopen it

@manasmulay manasmulay reopened this Aug 29, 2024
@manasmulay manasmulay marked this pull request as ready for review August 29, 2024 04:02
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10608461877

Details

  • 49 of 57 (85.96%) changed or added relevant lines in 2 files are covered.
  • 271 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-2.0%) to 66.061%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/server/server.go 45 49 91.84%
pkg/server/utils.go 4 8 50.0%
Files with Coverage Reduction New Missed Lines %
pkg/backup/download.go 2 73.76%
pkg/backup/create.go 2 75.68%
pkg/backup/restore.go 2 67.54%
cmd/clickhouse-backup/main.go 2 79.53%
pkg/storage/object_disk/object_disk.go 5 69.43%
pkg/status/status.go 9 70.2%
pkg/config/config.go 10 72.49%
pkg/backup/backuper.go 18 64.16%
pkg/server/server.go 18 56.91%
pkg/storage/general.go 22 61.2%
Totals Coverage Status
Change from base Build 10602348319: -2.0%
Covered Lines: 8720
Relevant Lines: 13200

💛 - Coveralls

@Slach
Copy link
Collaborator

Slach commented Aug 29, 2024

thanks for contribution

@Slach Slach merged commit 3109f69 into Altinity:master Aug 29, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants