Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated created datetime to utc #784

Merged
merged 6 commits into from
Mar 18, 2024
Merged

Updated created datetime to utc #784

merged 6 commits into from
Mar 18, 2024

Conversation

acn-dgopa
Copy link
Member

Description

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Copy link
Member

@jonkjetiloye jonkjetiloye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the #nullable enable to the EventLog classes where you're using nullable to get rid of the warnings?

Would also be nice to fix the technical debt of using ISystemClock which is obsolete, as I guess this will be one of the last changes on AuditLog for a while?

@acn-dgopa
Copy link
Member Author

Can you add the #nullable enable to the EventLog classes where you're using nullable to get rid of the warnings?

Would also be nice to fix the technical debt of using ISystemClock which is obsolete, as I guess this will be one of the last changes on AuditLog for a while?

thats right. I was waiting to rewrite both in authentication and authorization when upgraded to .net8. I see authz is updated to .net8. I will fix this

Copy link

@acn-dgopa acn-dgopa merged commit ea1491e into main Mar 18, 2024
7 of 8 checks passed
@acn-dgopa acn-dgopa deleted the bug/timezone branch March 18, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Created date and time which shows in logs is different than the actual time in audit log
3 participants