-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error variant for Panel #69
Conversation
Marked this draft because I'm still not sure if this is where we want it to be. @haakemon Could you take a look at this and tell me how strict we want to be? Right now I'm using Should we (1) wait for the proper alias and icon for some weeks until the relevant people is back from their holiday, or (2) remove the TODOs from the code, create an issue to track these needs, and continue on a faster track to getting this PR ready for merging: |
I think option 2 is best - no problem to use the generic variables until specific ones are created. As for the icons, there has been some back and forth how they should look in the different variants, so we should tackle that separately anyway :) Should add a test for the error icon as well |
Created new issues: Removed TODOs from the code. Also pushed the missing unit test (sorry, I added that yesterday but forgot to push it! 😆) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff!
Description
Adding an error variant for the Panel component. Needed for the linked issue.
Related Issue(s)
Verification
Documentation