Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guide multi app solution #1085

Merged
merged 46 commits into from
Nov 24, 2023
Merged

Guide multi app solution #1085

merged 46 commits into from
Nov 24, 2023

Conversation

standeren
Copy link
Contributor

Description

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@standeren standeren force-pushed the guide-multi-app-solution branch 3 times, most recently from b716525 to f351691 Compare August 24, 2023 14:21
@standeren standeren force-pushed the guide-multi-app-solution branch 2 times, most recently from d314b0b to 29f1097 Compare September 14, 2023 11:27
@standeren standeren force-pushed the guide-multi-app-solution branch 5 times, most recently from 4a0e96b to 6086e86 Compare September 29, 2023 13:58
@acn-sbuad
Copy link
Contributor

acn-sbuad commented Nov 7, 2023 •
edited
Loading

General feedback: go over and be consistent in the referencing of application A and B.
Is it Application A or application A?

nkylstad
nkylstad reviewed Nov 16, 2023
View reviewed changes
Copy link
Member

@nkylstad nkylstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great! I added some suggestions/comments for you to consider. Would also like the norwegian translations here 😇

content/app/guides/multi-app-solution/_index.nb.md Outdated Show resolved Hide resolved
content/app/guides/multi-app-solution/_index.en.md Outdated Show resolved Hide resolved
content/app/guides/multi-app-solution/_index.en.md Outdated Show resolved Hide resolved
content/app/guides/multi-app-solution/_index.en.md Outdated Show resolved Hide resolved
content/app/guides/multi-app-solution/_index.en.md Outdated Show resolved Hide resolved
content/app/guides/multi-app-solution/instructions/app-a/_index.en.md Outdated Show resolved Hide resolved
content/app/guides/multi-app-solution/instructions/app-b/_index.en.md Outdated Show resolved Hide resolved
content/app/guides/multi-app-solution/multi-app-architecture.drawio.svg Outdated Show resolved Hide resolved
content/app/guides/multi-app-solution/testing/_index.en.md Outdated Show resolved Hide resolved
content/app/guides/multi-app-solution/testing/_index.en.md Show resolved Hide resolved
standeren and others added 15 commits November 22, 2023 14:43
@standeren
Change formulation in prerequisites for instructions
8568b66
@standeren @nkylstad
Update content/app/guides/multi-app-solution/_index.en.md
16d9ea4 
Co-authored-by: Nina Kylstad <[email protected]>
@standeren @nkylstad
Update content/app/guides/multi-app-solution/_index.en.md
c972ae7 
Co-authored-by: Nina Kylstad <[email protected]>
@standeren @nkylstad
Update content/app/guides/multi-app-solution/_index.en.md
a1f43cc 
Co-authored-by: Nina Kylstad <[email protected]>
@standeren @nkylstad
Update content/app/guides/multi-app-solution/_index.en.md
4c21f0c 
Co-authored-by: Nina Kylstad <[email protected]>
@standeren @nkylstad
Update content/app/guides/multi-app-solution/instructions/app-a/_inde…
8a4399d 
…x.en.md

Co-authored-by: Nina Kylstad <[email protected]>
@standeren @nkylstad
Update content/app/guides/multi-app-solution/_index.en.md
4d42702 
Co-authored-by: Nina Kylstad <[email protected]>
@standeren @nkylstad
Update content/app/guides/multi-app-solution/_index.en.md
4f140be 
Co-authored-by: Nina Kylstad <[email protected]>
@standeren @nkylstad
Update content/app/guides/multi-app-solution/testing/_index.en.md
3909ea9 
Co-authored-by: Nina Kylstad <[email protected]>
@standeren @nkylstad
Update content/app/guides/multi-app-solution/_index.en.md
1187b4c 
Co-authored-by: Nina Kylstad <[email protected]>
@standeren @nkylstad
Update content/app/guides/multi-app-solution/_index.en.md
cac3b1a 
Co-authored-by: Nina Kylstad <[email protected]>
@standeren @nkylstad
Update content/app/guides/multi-app-solution/instructions/app-a/_inde…
bcb0be0 
…x.en.md

Co-authored-by: Nina Kylstad <[email protected]>
@standeren @nkylstad
Update content/app/guides/multi-app-solution/instructions/app-a/_inde…
0ead7fa 
…x.en.md

Co-authored-by: Nina Kylstad <[email protected]>
@standeren
Merge branch 'master' into guide-multi-app-solution
2151b02
@standeren
Fix PR comments
67269b1
@standeren standeren force-pushed the guide-multi-app-solution branch 3 times, most recently from 8e44683 to f03d685 Compare November 22, 2023 16:19
@standeren standeren force-pushed the guide-multi-app-solution branch from f03d685 to 9d8eea2 Compare November 22, 2023 16:28
nkylstad
nkylstad approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@nkylstad nkylstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Godt jobbet 🥳

@standeren standeren merged commit ea666cb into master Nov 24, 2023
1 check passed
@standeren standeren deleted the guide-multi-app-solution branch November 24, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acn-sbuad acn-sbuad acn-sbuad left review comments

@nkylstad nkylstad nkylstad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@standeren @acn-sbuad @nkylstad