Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for Docker #1338

Merged
merged 7 commits into from
Feb 14, 2024
Merged

Add documentation for Docker #1338

merged 7 commits into from
Feb 14, 2024

Conversation

mlqn
Copy link
Contributor

@mlqn mlqn commented Dec 13, 2023 •
edited
Loading

Description

Add documentation for Docker installation

  • with Docker Desktop
  • without Docker Desktop for macOS

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@mlqn mlqn marked this pull request as draft December 13, 2023 14:21
@mlqn mlqn marked this pull request as ready for review February 14, 2024 11:47
nkylstad
nkylstad approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@nkylstad nkylstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@mlqn mlqn merged commit 0664608 into master Feb 14, 2024
1 check passed
@mlqn mlqn deleted the feature/docker-guidelines branch February 14, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkylstad nkylstad nkylstad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlqn @nkylstad