Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic start of Broker Transition Solution Documentation #1570

Merged
merged 42 commits into from
Jun 3, 2024
Merged

Basic start of Broker Transition Solution Documentation #1570

merged 42 commits into from
Jun 3, 2024

Conversation

tomshag
Copy link
Contributor

@tomshag tomshag commented Apr 24, 2024

Basic start of Broker Transition Solution Documentation

Description

Basic start of Broker Transition Solution Documentation

@tomshag tomshag self-assigned this Apr 24, 2024
Copy link
Contributor

@RagnarFatland-Avanade RagnarFatland-Avanade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plenty of good stuff here, but I have some comments. Complete those and we can have a new review before a translation to Norwegian.

.vscode/settings.json Outdated Show resolved Hide resolved
content/broker/broker-transition/_index.en.md Show resolved Hide resolved
content/broker/broker-transition/usage/rest/_index.en.md Outdated Show resolved Hide resolved
content/broker/broker-transition/usage/rest/_index.en.md Outdated Show resolved Hide resolved
content/broker/broker-transition/usage/rest/_index.en.md Outdated Show resolved Hide resolved
Copy link
Contributor

@RagnarFatland-Avanade RagnarFatland-Avanade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need the translation to Norwegian.

@tomshag
Copy link
Contributor Author

tomshag commented May 22, 2024

Looks good, just need the translation to Norwegian.

Norwegian translated pages have now been added.

@tomshag tomshag marked this pull request as ready for review May 28, 2024 07:06
Copy link
Contributor

@RagnarFatland-Avanade RagnarFatland-Avanade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks OK, but needs consistent use of translated terms as this differs some places.
Some terms like status codes/operations should not be translated to Norwegian, but instead quoted in original English versions,
Some of the translated text needs to be cleaned up/refactored slightly due to whitespacing and/or grammatical inconsistencies in norwegian versions..

content/broker/broker-transition/_index.nb.md Show resolved Hide resolved
content/broker/broker-transition/_index.nb.md Outdated Show resolved Hide resolved
content/broker/broker-transition/_index.nb.md Outdated Show resolved Hide resolved
content/broker/broker-transition/_index.nb.md Outdated Show resolved Hide resolved
content/broker/broker-transition/_index.nb.md Outdated Show resolved Hide resolved
content/broker/broker-transition/usage/rest/_index.nb.md Outdated Show resolved Hide resolved
content/broker/broker-transition/usage/rest/_index.en.md Outdated Show resolved Hide resolved
content/broker/broker-transition/usage/rest/_index.nb.md Outdated Show resolved Hide resolved
content/broker/broker-transition/usage/rest/_index.nb.md Outdated Show resolved Hide resolved
Copy link
Contributor

@RagnarFatland-Avanade RagnarFatland-Avanade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@tomshag tomshag merged commit b7e6c6f into Altinn:master Jun 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants