Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options rewrite fixes #1952

Merged
merged 7 commits into from
Jan 11, 2025
Merged

Options rewrite fixes #1952

merged 7 commits into from
Jan 11, 2025

Conversation

olemartinorg
Copy link
Contributor

Fixes after review - #1934

@olemartinorg olemartinorg self-assigned this Jan 2, 2025
@olemartinorg olemartinorg requested a review from cammiida January 2, 2025 16:24
@olemartinorg
Copy link
Contributor Author

@cammiida Let me know if you get a chance to look this over and approve. 🙌

Copy link
Contributor

@cammiida cammiida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Veldig nice! Bare noen småkommentarer 💯

@olemartinorg olemartinorg merged commit 63c2f7d into master Jan 11, 2025
4 checks passed
@olemartinorg olemartinorg deleted the options-rewrite-fixes branch January 11, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants