Supporting component
and dataModel
lookups in optionFilter
when using source options
#2839
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After the
optionFilter
property was added, in an unrelated task, I saw that filtering the 'repeating group-sourced' options on the 'Pets' page inttd/frontend-test
was a perfect use-case foroptionFilter
. In order to filter out repeating group rows that had not been filled out yet, it was painfully obvious that the filter should support lookups per row when each option comes from a row.So, this functionality allows this expression filter to work:
This
Checkboxes
component will get options from thePets
repeating group, but rows where all the fields are null (Age
,Name
andSpecies
) will be filtered out. I was also able to do this using the existingvalue
function, but it's much more fiddly, brittle and difficult to work with - looking up in the data model directly is obviously better.Also,
component
lookups will work as well (but only if there is aRepeatingGroup
bound to the path in the data model -dataModel
lookups will work regardless).Related Issue(s)
Verification/QA
kind/*
label to this PR for proper release notes grouping