Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
aria-labelledby
in the new Option component (I only did it in all the others), so that needs fixingttd/frontend-test
and percy snapshots, so I don't see a need for frequent pushes to this branch.Description
Adding the
Option
presentation component, as described in #2752. It can be configured as such:The list of options can be configured just like any other option-supporting component, and the selected option value should be placed in the
value
property (which will usually call an expression).Details:
Option
component doesn't support any option-effects (i.e. it cannot store the label for the selected value into the data model, and it will not remove invalid values from the data model, etc).In the process I also fixed a few problems in the existing
Text
,Number
andDate
components:useNodeItem()
for each property instead of getting all of them. Fetching everything is overkill, just likeSELECT * FROM table
.title
text resource binding in the icon alt textaria-labelledby
even when there is no labelRelated Issue(s)
Option
component (presentation component similar toText
,Number
andDate
) #2752Verification/QA
kind/*
label to this PR for proper release notes grouping