Code

Removing most node traversal usages#3009

Code

Open

olemartinorg wants to merge 22 commits intomainAltinn/app-frontend-react:mainfrom chore/removing-more-traversalAltinn/app-frontend-react:chore/removing-more-traversalCopy head branch name to clipboard

+638-605

Commits

Commits on Feb 13, 2025

• Fixing some low-hanging node traversal usages

  

  Ole Martin Handeland

  committed
  35d2398

  Copy full SHA for 35d2398

• Adding depth and parentId to node state, so that more traversal can be rewritten to be selectors

  

  Ole Martin Handeland

  committed
  70a77e5

  Copy full SHA for 70a77e5

• Removing more traversal

  

  Ole Martin Handeland

  committed
  d1a8b0c

  Copy full SHA for d1a8b0c

• Rewriting node traversal in Form.tsx

  

  Ole Martin Handeland

  committed
  bccc461

  Copy full SHA for bccc461

Commits on Feb 14, 2025

• Rewriting more node traversal. This one is a bit risky, as nodes.allNodes() returned every node in pages in pageOrder, but nodeData included these implicitly hidden nodes. Removing generation of th…

  Show description for 2293143
  

  Ole Martin Handeland

  committed
  2293143

  Copy full SHA for 2293143

• Fixing some things I broke when checking for hidden components

  

  Ole Martin Handeland

  committed
  699e49b

  Copy full SHA for 699e49b

• Whoops, FormPage didn't really care about the page key it was given. This might have been a bug for a while!

  

  Ole Martin Handeland

  committed
  863f7bb

  Copy full SHA for 863f7bb

• No point in reading layout settings twice

  

  Ole Martin Handeland

  committed
  cec1bcf

  Copy full SHA for cec1bcf

• A layout is also valid if it's the pdf layout (and nodes should be generated)

  

  Ole Martin Handeland

  committed
  a4dd94d

  Copy full SHA for a4dd94d

• Removing useEffectWhenReady() and replacing it with a simpler/more direct method. This failed hard _sometimes_ in the pdf.ts test, seemingly because the clearTimeout() that ran here failed hard whe…

  Show description for 8b148bb
  

  Ole Martin Handeland

  committed
  8b148bb

  Copy full SHA for 8b148bb

• Making sure these tests wait until preselectedOptionIndex etc is saved to the backend before it continues to test the pdf.

  

  Ole Martin Handeland

  committed
  2aedb79

  Copy full SHA for 2aedb79

• Huh, there were more easy ones - I missed these.

  

  Ole Martin Handeland

  committed
  40192f6

  Copy full SHA for 40192f6

• Oooh, sneaky! I'm so glad to have tests that catch me messing up a 0 !== undefined check

  

  Ole Martin Handeland

  committed
  91b17d9

  Copy full SHA for 91b17d9

• Merge branch 'main' into chore/removing-more-traversal

  

  Ole Martin Handeland

  committed
  c85a0bb

  Copy full SHA for c85a0bb

• Replacing a few more traversals

  

  Ole Martin Handeland

  committed
  47308ef

  Copy full SHA for 47308ef

Commits on Feb 15, 2025

• [no ci] Whoops, my simpler fix failed to re-run the useEffect, breaking preselectedOptionIndex among others

  

  Ole Martin Handeland

  committed
  3c87105

  Copy full SHA for 3c87105

Commits on Feb 17, 2025

• Instead of skipping node generation for implicitly hidden pages, mark them as 'isValid: false' instead, and use that info to not include them in validation selectors.

  

  Ole Martin Handeland

  committed
  a8413f6

  Copy full SHA for a8413f6

• Removing node traversal (and all the delayed selector usage!) from useAttachmentDeletionInRepGroups.ts

  

  Ole Martin Handeland

  committed
  f4500fa

  Copy full SHA for f4500fa

• Yay, an easy one!

  

  Ole Martin Handeland

  committed
  03a45b6

  Copy full SHA for 03a45b6

• There were not as simple, but I think the pagination one got considerably cheaper to run now

  

  Ole Martin Handeland

  committed
  7bcc40b

  Copy full SHA for 7bcc40b

• Rewriting the remaining usages of node traversal that I found fairly easy to rewrite

  

  Ole Martin Handeland

  committed
  368aa15

  Copy full SHA for 368aa15

• Moving attachmentSelector to fix import error when running RepeatingGroupTable.test.tsx

  

  Ole Martin Handeland

  committed
  9247738

  Copy full SHA for 9247738