Skip to content

Feat/expression on validation message #3454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

paal2707
Copy link
Contributor

Description

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* and backport* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@paal2707 paal2707 added org/ssb Issues relevant for Statistisk sentralbyrå. kind/product-feature Pull requests containing new features backport-ignore This PR is a new feature and should not be cherry-picked onto release branches labels Jun 16, 2025
@ivarne
Copy link
Member

ivarne commented Jun 17, 2025

Litt uheldig å kjøre inn slik funksjonalitet uten tester.

I det minste bør du ta inn test/Altinn.App.Core.Tests/Features/Validators/expression-validation-tests/shared/many-errors-direct.json fra Altinn/app-lib-dotnet#1333

@paal2707 paal2707 closed this Jun 17, 2025
@paal2707
Copy link
Contributor Author

Litt uheldig å kjøre inn slik funksjonalitet uten tester.

I det minste bør du ta inn test/Altinn.App.Core.Tests/Features/Validators/expression-validation-tests/shared/many-errors-direct.json fra Altinn/app-lib-dotnet#1333

Jeg har endret i appen for expression-validation og lagt inn config med expression, så den cypress(e2e) testen vi har fra før av tester både med og uten utrykk nå.

@paal2707 paal2707 reopened this Jun 17, 2025
@ivarne
Copy link
Member

ivarne commented Jun 17, 2025

Likevel, det jeg lenket til er en delt test som du antakelig bare kan kopiere over endringene til

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-ignore This PR is a new feature and should not be cherry-picked onto release branches kind/product-feature Pull requests containing new features org/ssb Issues relevant for Statistisk sentralbyrå.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validering med uttrykk: Støtte for utrykk på "message"
2 participants