Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic buffers to f3write #190

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Add dynamic buffers to f3write #190

merged 1 commit into from
Nov 11, 2022

Conversation

AltraMayor
Copy link
Owner

The write buffer passed to the operating system has previously been limited to MAX_BUFFER_SIZE. This commit makes it dynamically sized in order to reach maximum writing speeds.

See details on issue #188.

The write and read buffers passed to the operating system have
previously been limited to MAX_BUFFER_SIZE.  This commit makes
them dynamically sized in order to reach maximum writing and
reading speeds.

See details on issue #188.
@r2dd2
Copy link

r2dd2 commented Nov 10, 2022

I am testing the new f3read now. The previous f3read was already fast:
Validating file 3723.h2w ... 2097152/ 0/ 0/ 0
Validating file 3724.h2w ... 2097152/ 0/ 0/ 0
Validating file 3725.h2w ... 2097152/ 0/ 0/ 0
Validating file 3726.h2w ... 1766424/ 0/ 0/ 0

Data OK: 3.64 TB (7813657624 sectors)
Data LOST: 0.00 Byte (0 sectors)
Corrupted: 0.00 Byte (0 sectors)
Slightly changed: 0.00 Byte (0 sectors)
Overwritten: 0.00 Byte (0 sectors)
Average reading speed: 144.86 MB/s

I had run it to see if there were any errors shown as you said that the last bytes or buffers would not be written.

The current test should be ready in 8h as the files written with the dynamic buffer and flushing disabled are still on my drive.

@AltraMayor AltraMayor marked this pull request as ready for review November 11, 2022 23:50
@AltraMayor AltraMayor merged commit a7c13b1 into master Nov 11, 2022
@AltraMayor AltraMayor deleted the wbuf branch November 11, 2022 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants