fix(apis-manager): allow Api Interface to retrieve and set configs (#…

…1990)
AmadeusITGroup · Jul 24, 2024 · d724bf1 · d724bf1
2 parents 8765cf4 + 1df8cac
commit d724bf1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/packages/@o3r/apis-manager/README.md b/packages/@o3r/apis-manager/README.md
@@ -182,7 +182,7 @@ class MyClass {
   }
 
   doSomething() {
-    this.apiManager.setConfiguration(new ApiFetchClient(), ExampleApi); // <- override configuration of Example API
+    this.apiManager.setConfiguration(new ApiFetchClient(), ExampleApi.apiName); // <- override configuration of Example API
     const exampleApi = this.apiFactoryService.getApi(ExampleApi, true); // <- retrieve example API with the new configuration (and refresh the cache)
   }
 

diff --git a/packages/@o3r/apis-manager/src/apis-manager/api-manager.ts b/packages/@o3r/apis-manager/src/apis-manager/api-manager.ts
@@ -1,4 +1,4 @@
-import type { ApiClient } from '@ama-sdk/core';
+import type { Api, ApiClient } from '@ama-sdk/core';
 
 /**
  * Api manager is responsible to provide an api configuration to a service factory, so that it could instantiate an API
@@ -31,18 +31,18 @@ export class ApiManager {
    * Retrieve a configuration for a specific API
    * @param api API to get the configuration for
    */
-  public getConfiguration(api?: string): ApiClient {
-    return api && this.apiConfigurations[api] || this.defaultConfiguration;
+  public getConfiguration(api?: string | Api): ApiClient {
+    return api && this.apiConfigurations[typeof api === 'string' ? api : api.apiName] || this.defaultConfiguration;
   }
 
   /**
    * Set or override API configuration
    * @param apiClient API configuration to override to the given api
    * @param api API name to override, the default configuration will be used if not specified
    */
-  public setConfiguration(apiClient: ApiClient, api?: string): void {
+  public setConfiguration(apiClient: ApiClient, api?: string | Api): void {
     if (api) {
-      this.apiConfigurations[api] = apiClient;
+      this.apiConfigurations[typeof api === 'string' ? api : api.apiName] = apiClient;
     } else {
       this.defaultConfiguration = apiClient;
     }