feat(sdk): provide a way to request a custom URL and add apiName in request plugin context #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b5c1252. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
github-actions
bot
added
enhancement
kpanot
force-pushed
the
feature/sdk-generic-request
branch
2 times, most recently
from
2202aa8 to
efb43b3
Compare
fpaul-1A
reviewed
Apr 3, 2024
fpaul-1A
reviewed
Apr 3, 2024
fpaul-1A
previously approved these changes
Apr 3, 2024
kpanot
force-pushed
the
feature/sdk-generic-request
branch
from
efb43b3 to
15e1a6c
Compare
fpaul-1A
previously approved these changes
Apr 3, 2024
kpanot
changed the title
mrednic-1A
reviewed
Apr 15, 2024
kpanot
force-pushed
the
feature/sdk-generic-request
branch
2 times, most recently
from
37e3928 to
a1fc7e4
Compare
mrednic-1A
previously approved these changes
Apr 18, 2024
kpanot
force-pushed
the
feature/sdk-generic-request
branch
2 times, most recently
from
623d0f1 to
805c9bc
Compare
feat(sdk): add apiName in the request plugin context
kpanot
force-pushed
the
feature/sdk-generic-request
branch
from
805c9bc to
492ae01
Compare
kpanot
commented
Apr 23, 2024
| * @param specification Specification single object to parse | ||
| */ | ||
| // eslint-disable-next-line camelcase | ||
| export const generateOperationFinderFromSingleFile = (specification: OpenAPIV2.Document | OpenAPIV3.Document | OpenAPIV3_1.Document): PathObject[] => { |
There was a problem hiding this comment.
Created #1699 to handle complex path resolution
mrednic-1A
approved these changes
Apr 23, 2024
fpaul-1A
approved these changes
Apr 23, 2024
This was referenced Apr 23, 2024
mrednic-1A
added a commit
that referenced
this pull request
Apr 24, 2024
## Proposed change <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that is required for this change. --> ## Related issues - 🐛 Fixes #(issue) - 🚀 Feature #(issue) <!-- Please make sure to follow the contributing guidelines on https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md --> cherry-pick from #1578
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
feat(sdk): provide a way to request a custom URL
feat(sdk): add apiName in the request plugin context
The purpose of this PR is to offer a way to do manually a request in the context of the SDK and benefit of the plugins register.
To facilitate the identification of the request in the requestPlugin (as done in the replyPlugin), the context is provided to the request plugin.