docs(components): update documentation on components #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 83337c0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
github-actions
bot
added
documentation
matthieu-crouzet
force-pushed
the
docs/components
branch
from
0f1188f to
272e3c2
Compare
matthieu-crouzet
force-pushed
the
docs/components
branch
from
272e3c2 to
032954f
Compare
sdo-1A
reviewed
Apr 4, 2024
matthieu-crouzet
force-pushed
the
docs/components
branch
from
9d0d606 to
9af489a
Compare
sdo-1A
reviewed
Apr 4, 2024
matthieu-crouzet
force-pushed
the
docs/components
branch
from
9af489a to
1a76180
Compare
sdo-1A
previously approved these changes
Apr 4, 2024
matthieu-crouzet
force-pushed
the
docs/components
branch
from
1a76180 to
47db863
Compare
sdo-1A
reviewed
Apr 4, 2024
sdo-1A
reviewed
Apr 5, 2024
cpaulve-1A
reviewed
Apr 5, 2024
cpaulve-1A
reviewed
Apr 5, 2024
cpaulve-1A
reviewed
Apr 5, 2024
cpaulve-1A
reviewed
Apr 5, 2024
cpaulve-1A
reviewed
Apr 5, 2024
| ```` | ||
|
|
||
| Are not possible through an ``ng-template`` and ``c11n`` combination. | ||
|
|
||
| Though there is a solution for the first example in making the value an input, and bind it inside the component using | ||
| the [HostBinding](https://angular.io/api/core/HostBinding) decorator, there is no actual solution for applying directive. | ||
| A [feature request](https://github.com/angular/angular/issues/8785) has been opened for a long time and finally made it |
There was a problem hiding this comment.
Now that the feature request finally made it, what is the next step ? :D
cpaulve-1A
reviewed
Apr 5, 2024
matthieu-crouzet
commented
Apr 5, 2024
matthieu-crouzet
force-pushed
the
docs/components
branch
from
8a14754 to
5ade442
Compare
matthieu-crouzet
force-pushed
the
docs/components
branch
4 times, most recently
from
dee10a4 to
5975a5c
Compare
pginoux-1A
reviewed
Aug 28, 2024
matthieu-crouzet
force-pushed
the
docs/components
branch
from
5975a5c to
df9858c
Compare
pginoux-1A
reviewed
Aug 28, 2024
cpaulve-1A
reviewed
Aug 28, 2024
fpaul-1A
reviewed
Aug 28, 2024
matthieu-crouzet
force-pushed
the
docs/components
branch
2 times, most recently
from
d751810 to
48859f2
Compare
cpaulve-1A
reviewed
Aug 28, 2024
| @@ -1,22 +1,21 @@ | |||
| # Component replacement | |||
|
|
|||
| ## Overview | |||
|
|
|||
| The goal of the feature is to make a component replaceable at runtime. | |||
There was a problem hiding this comment.
In which context?
Why do we need runtime replacement and can't just build an app as we wish to?
The idea might seem overkill so we should also introduce the reason for this need
cpaulve-1A
reviewed
Aug 28, 2024
|
|
||
| * The type of the component to instantiate | ||
| * The inputs and outputs to bind | ||
| * The potential configuration override to apply | ||
|
|
||
| Now let's see how to use that mechanism in practice. | ||
| Now let's see how to set this mechanism up to create your replacable components. | ||
|
|
||
| ## Prepare your base app to register custom components | ||
|
|
There was a problem hiding this comment.
We don't use again the customProviders in this document, should we keep this part?
cpaulve-1A
reviewed
Aug 28, 2024
| @@ -1,22 +1,21 @@ | |||
| # Component replacement | |||
There was a problem hiding this comment.
There are many mentions of customization app/base app but we never introduce the concepts and we do not provide the script apply custo. We should probably rewrite this example and provide a simple example with a fetch of the replacement map
cpaulve-1A
reviewed
Aug 28, 2024
cpaulve-1A
reviewed
Aug 28, 2024
cpaulve-1A
reviewed
Aug 28, 2024
cpaulve-1A
reviewed
Aug 28, 2024
matthieu-crouzet
force-pushed
the
docs/components
branch
from
48859f2 to
cabe582
Compare
pginoux-1A
previously approved these changes
Aug 29, 2024
matthieu-crouzet
force-pushed
the
docs/components
branch
from
cabe582 to
83337c0
Compare
fpaul-1A
approved these changes
Aug 29, 2024
vscaiceanu-1a
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Update documentation for components