-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): add the capability to clear dictionary field #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
New feature or request
project:@ama-sdk/schematics
labels
Aug 14, 2024
Shouldn't we re-generate the o3r showcase sdk with that ? |
cpaulve-1A
previously approved these changes
Aug 14, 2024
cpaulve-1A
reviewed
Aug 14, 2024
kpanot
force-pushed
the
feature/no-dictionary
branch
4 times, most recently
from
August 15, 2024 07:01
8aa8ce8
to
7623af1
Compare
kpanot
force-pushed
the
feature/no-dictionary
branch
from
August 15, 2024 08:21
7623af1
to
c52b806
Compare
mrednic-1A
reviewed
Aug 19, 2024
kpanot
force-pushed
the
feature/no-dictionary
branch
from
August 29, 2024 09:27
c52b806
to
5ed6f1e
Compare
kpanot
changed the title
feat(sdk-schematics): expose models without dictionary
feat(sdk): add the capability to clear dictionary field
Aug 29, 2024
kpanot
force-pushed
the
feature/no-dictionary
branch
from
August 29, 2024 09:28
5ed6f1e
to
a34a27d
Compare
Will not affect showcase SDK, the changes are on not generated files (revivers) |
matthieu-crouzet
previously approved these changes
Aug 29, 2024
kpanot
force-pushed
the
feature/no-dictionary
branch
from
August 29, 2024 09:35
a34a27d
to
0e5fd06
Compare
fpaul-1A
previously approved these changes
Aug 29, 2024
kpanot
force-pushed
the
feature/no-dictionary
branch
from
August 29, 2024 09:45
0e5fd06
to
04da345
Compare
fpaul-1A
reviewed
Aug 29, 2024
kpanot
force-pushed
the
feature/no-dictionary
branch
from
August 29, 2024 09:54
04da345
to
02e6e9a
Compare
cpaulve-1A
approved these changes
Aug 29, 2024
vscaiceanu-1a
approved these changes
Aug 29, 2024
pginoux-1A
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
feat(sdk): add the capability to clear dictionary field
Related issues