Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): add the capability to clear dictionary field #2059

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

kpanot
Copy link
Contributor

@kpanot kpanot commented Aug 14, 2024

Proposed change

feat(sdk): add the capability to clear dictionary field

Related issues

@kpanot kpanot requested a review from a team as a code owner August 14, 2024 09:18
@matthieu-crouzet
Copy link
Contributor

Shouldn't we re-generate the o3r showcase sdk with that ?

cpaulve-1A
cpaulve-1A previously approved these changes Aug 14, 2024
@kpanot kpanot force-pushed the feature/no-dictionary branch 4 times, most recently from 8aa8ce8 to 7623af1 Compare August 15, 2024 07:01
@kpanot kpanot marked this pull request as draft August 15, 2024 08:14
@kpanot kpanot force-pushed the feature/no-dictionary branch from 7623af1 to c52b806 Compare August 15, 2024 08:21
@kpanot kpanot force-pushed the feature/no-dictionary branch from c52b806 to 5ed6f1e Compare August 29, 2024 09:27
@kpanot kpanot changed the title feat(sdk-schematics): expose models without dictionary feat(sdk): add the capability to clear dictionary field Aug 29, 2024
@kpanot kpanot marked this pull request as ready for review August 29, 2024 09:28
@kpanot kpanot force-pushed the feature/no-dictionary branch from 5ed6f1e to a34a27d Compare August 29, 2024 09:28
@kpanot
Copy link
Contributor Author

kpanot commented Aug 29, 2024

Shouldn't we re-generate the o3r showcase sdk with that ?

Will not affect showcase SDK, the changes are on not generated files (revivers)

fpaul-1A
fpaul-1A previously approved these changes Aug 29, 2024
@kpanot kpanot force-pushed the feature/no-dictionary branch from 04da345 to 02e6e9a Compare August 29, 2024 09:54
@kpanot kpanot added this pull request to the merge queue Aug 30, 2024
Merged via the queue into main with commit afe641a Aug 30, 2024
28 checks passed
@kpanot kpanot deleted the feature/no-dictionary branch August 30, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Mandatory dictionary field remain mandatory when part of the request
7 participants