Feat/training merge main #2541
Merged
Feat/training merge main #2541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncies on postinstall
…epending on the presence of eslintrc or not
…epending on the presence of eslintrc or not (#2193) ## Proposed change - Select `@o3r/eslint-config` or `@o3r/eslint-config-otter` depending on the presence of eslintrc or not - Use `@o3r/eslint-config` when generating a shell sdk
…config (#2201) ## Proposed change Set relative path instead of absolute path in the merge config
## Proposed change As discussed, adding angular [recommended config](https://github.com/angular-eslint/angular-eslint/tree/main/packages/angular-eslint/src/configs#angular-eslinttemplate-accessibility) for accessibility
## Proposed change As discussed move all warnings into errors. Open to discussion if some rules should become `off` instead of `errors`
…lphabetize (#2273) ## Proposed change One import per line Import alphabetize Export all alphabetize
…ve (#2274) ## Proposed change Require a description when using eslint disable directive
## Proposed change Change default vscode config
## Proposed change Update documentation for eslint flat config - [x] Review the ESLint configuration with the team
## Proposed change Run the auto-fix with the new config ## Rules to discuss - [x] [@eslint-community/eslint-comments/disable-enable-pair](https://github.com/mysticatea/eslint-plugin-eslint-comments/blob/master/docs/rules/disable-enable-pair.md) => off - [x] [unicorn/prefer-type-error](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-type-error.md) => off - [x] [unicorn/numeric-separators-style](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/numeric-separators-style.md) => keep - [x] [unicorn/no-useless-promise-resolve-reject](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-useless-promise-resolve-reject.md) => off - [x] [@stylistic/operator-linebreak](https://eslint.style/rules/js/operator-linebreak) `"before", { "overrides": { "=": "after"} }` - [x] [unicorn/no-useless-undefined](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-useless-undefined.md) => keep until issue with mandatory params - [x] [unicorn/prefer-set-has](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-set-has.md) => off - [x] [@stylistic/arrow-parens](https://eslint.style/rules/js/arrow-parens) => keep - [x] [unicorn/prefer-prototype-methods](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-prototype-methods.md) => keep - [x] [unicorn/prefer-string-slice](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-string-slice.md) => off ## Missing rules - [ ] [max-len](https://eslint.org/docs/latest/rules/max-len) - [x] [require-await](https://eslint.org/docs/latest/rules/require-await)
## Proposed change
Apply eslint auto-run (remaining rules on import).
removed rule override:
```
'import/first': 'off',
'import/order': 'off',
'import/newline-after-import': 'off',
'import-newlines/enforce': 'off',
'@stylistic/object-curly-spacing': 'off',
'@stylistic/no-multiple-empty-lines': 'off',
'@stylistic/brace-style': 'off',
'@stylistic/padded-blocks': 'off',
'@stylistic/block-spacing': 'off',
'@stylistic/template-curly-spacing': 'off'
```
Require to merge #2291
github-actions
bot
added
project:@o3r/github-cascading-app
project:@o3r/localization
project:@o3r/logger
project:@o3r/mobile
project:@o3r/new-version
project:@o3r/pipeline
project:@o3r/routing
project:@o3r/rules-engine
project:@o3r/schematics
project:@o3r/showcase
project:@o3r/store-sync
project:@o3r/storybook
project:@o3r/stylelint-plugin
project:@o3r/styling
project:@o3r/telemetry
project:@o3r/test-helpers
project:@o3r/testing
project:@o3r/third-party
project:@o3r/workspace
project:@o3r/workspace-helpers
project:audit-gh-action
project:cascading-gh-action
project:get-npm-tag-gh-action
project:new-version-gh-action
project:otter-devtools
project:release-gh-action
labels
fpaul-1A
approved these changes
Dec 2, 2024
mrednic-1A
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Merge main with eslint refacto into the training feature
Fix eslint issues
Related issues
- No issue associated -