Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(training): remove df dependencies to speed up the build #2559

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

fpaul-1A
Copy link
Contributor

@fpaul-1A fpaul-1A commented Dec 5, 2024

Proposed change

In training app monorepo:

  • Removed @design-factory import from styles.scss
  • Created a light css version to only fit the needs of our current training in styles.scss
html {
    font-family: "Amadeus", sans-serif;
    font-size: 1rem;
    font-weight: 400;
    line-height: 1.5;
    color: #1a1a1a;
}

html, body {
    margin: 0;
    padding: 0;
}

.table {
    width: 100%;

    caption {
        color: #666;
        text-align: left;
        padding: .75rem;
    }

    tr>th {
        text-align: left;
    }

    td, th {
        padding: .75em;
        border-bottom: 1px solid #ccc;
    }
}

.row {
    display: flex;
}

.col {
    width: 100%;
    padding: 0 .75rem;
}

.m-2 {
    margin: .25rem;
}

button {
    cursor: pointer;
    appearance: button;
    background: transparent;
    border: 1px solid #0c66e1;
    color: #0c66e1;
    padding: .3125rem 1rem;
    font-weight: 500;
    line-height: 1.5;
    font-size: 1rem;
    border-radius: .175rem;
}
  • Removed @design-factory and all its dependencies from package.json
  • Regenerated package-lock.json

Related issues

- No issue associated -

@fpaul-1A fpaul-1A requested a review from a team as a code owner December 5, 2024 17:35
Copy link

nx-cloud bot commented Dec 5, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0c73921. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@github-actions github-actions bot added enhancement New feature or request project:@o3r/showcase labels Dec 5, 2024
@fpaul-1A fpaul-1A merged commit 3545ad4 into feat/otter-training Dec 6, 2024
3 checks passed
@fpaul-1A fpaul-1A deleted the feat/otter-training-remove-df branch December 6, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants