Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: ignore nx links as invalid links #2574

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

cpaulve-1A
Copy link
Contributor

@cpaulve-1A cpaulve-1A commented Dec 9, 2024

Proposed change

Links requires authentication and are valid

Related issues

@cpaulve-1A cpaulve-1A requested a review from a team as a code owner December 9, 2024 16:20
@github-actions github-actions bot added the bug Something isn't working label Dec 9, 2024
@@ -11,6 +11,12 @@
},
{
"pattern": "^https?://(127.0.0.1|localhost)[:/].*"
},
{
"pattern": "^https?://(127.0.0.1|localhost)[:/].*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate of line 13 ?

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.19%. Comparing base (5cb8aeb) to head (3744b2d).

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vscaiceanu-1a
Copy link
Member

vscaiceanu-1a commented Dec 9, 2024

For change log purposes, the commit message should start with docs: rather than fix:.

@matthieu-crouzet
Copy link
Contributor

For change log purposes, the commit message should start with docs: rather than fix:.

The changelog take the PR labels into account we can keep the same commit message but change manually the PR labels

@cpaulve-1A cpaulve-1A changed the title fix: ignore nx links as invalid links doc: ignore nx links as invalid links Dec 13, 2024
Links requires authentication and are valid
@cpaulve-1A cpaulve-1A force-pushed the fix/ignore-unauthorize-links branch from 3744b2d to 900f7a1 Compare December 13, 2024 16:13
@matthieu-crouzet matthieu-crouzet added documentation Improvements or additions to documentation and removed bug Something isn't working labels Dec 16, 2024
@cpaulve-1A cpaulve-1A changed the title doc: ignore nx links as invalid links docs: ignore nx links as invalid links Dec 16, 2024
@cpaulve-1A cpaulve-1A added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit 82e621d Dec 16, 2024
27 checks passed
@cpaulve-1A cpaulve-1A deleted the fix/ignore-unauthorize-links branch December 16, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links are broken in the documentation
4 participants