-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: increase number of nx parallel task for build #2576
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files☔ View full report in Codecov by Sentry. |
@@ -39,6 +39,7 @@ jobs: | |||
runs-on: ubuntu-latest | |||
needs: [yarn_lock_check] | |||
env: | |||
NX_PARALLEL: 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we set that directly in GitHub settings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can but it will be apply to all nx command, not sure it is what we want.
I saw a time degradation for build
task but not for Unit test
which seems to be faster
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we really want to have a different value depending on the job? I think we should have the same value everywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we decide to not have the same value everywhere I would expect a comment to explain why do we not use the default one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok deal.
Let's cancel this PR, set 3 a default value and override in case by case
Proposed change
increase number of nx parallel task for build
Related issues
- No issue associated -