feat(training): persistence of code modifications #2579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 94c77f0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
matthieu-crouzet
force-pushed
the
feat/training-persistence
branch
from
07049b5 to
8bd110c
Compare
github-actions
bot
added
enhancement
apps/showcase/src/components/training/code-editor-view/code-editor-view.component.ts
Outdated
Show resolved
Hide resolved
matthieu-crouzet
force-pushed
the
feat/training-persistence
branch
2 times, most recently
from
1ca33b0 to
bd33426
Compare
kpanot
previously approved these changes
Dec 11, 2024
apps/showcase/src/components/training/code-editor-view/code-editor-view.component.ts
Outdated
Show resolved
Hide resolved
fpaul-1A
force-pushed
the
feat/otter-training-file-navigation
branch
from
1d63fad to
39fdfea
Compare
Base automatically changed from
feat/otter-training-file-navigation
to
feat/otter-training
December 13, 2024 08:53
matthieu-crouzet
force-pushed
the
feat/training-persistence
branch
3 times, most recently
from
57f8c9f to
ef2b604
Compare
fpaul-1A
reviewed
Dec 13, 2024
apps/showcase/src/components/training/code-editor-view/code-editor-view.component.ts
Outdated
Show resolved
Hide resolved
fpaul-1A
reviewed
Dec 13, 2024
apps/showcase/src/components/training/save-code-dialog/save-code-dialog.component.ts
Outdated
Show resolved
Hide resolved
matthieu-crouzet
force-pushed
the
feat/training-persistence
branch
from
ef2b604 to
2c4e518
Compare
cpaulve-1A
reviewed
Dec 13, 2024
apps/showcase/src/components/training/code-editor-view/code-editor-view.component.ts
Show resolved
Hide resolved
cpaulve-1A
reviewed
Dec 13, 2024
apps/showcase/src/components/training/code-editor-view/code-editor-view.component.ts
Outdated
Show resolved
Hide resolved
cpaulve-1A
reviewed
Dec 13, 2024
apps/showcase/src/components/training/save-code-dialog/save-code-dialog.template.html
Show resolved
Hide resolved
cpaulve-1A
reviewed
Dec 13, 2024
apps/showcase/src/components/training/save-code-dialog/save-code-dialog.template.html
Outdated
Show resolved
Hide resolved
cpaulve-1A
reviewed
Dec 13, 2024
apps/showcase/src/components/training/save-code-dialog/save-code-dialog.template.html
Outdated
Show resolved
Hide resolved
matthieu-crouzet
force-pushed
the
feat/training-persistence
branch
from
2c4e518 to
e2dbba7
Compare
cpaulve-1A
previously approved these changes
Dec 13, 2024
matthieu-crouzet
force-pushed
the
feat/training-persistence
branch
2 times, most recently
from
770241f to
3adcbec
Compare
matthieu-crouzet
dismissed stale reviews from cpaulve-1A and kpanot
made changes
fpaul-1A
approved these changes
Dec 16, 2024
matthieu-crouzet
force-pushed
the
feat/training-persistence
branch
from
3adcbec to
426abdd
Compare
fpaul-1A
reviewed
Dec 16, 2024
apps/showcase/src/components/training/code-editor-view/code-editor-view.component.ts
Outdated
Show resolved
Hide resolved
matthieu-crouzet
force-pushed
the
feat/training-persistence
branch
from
426abdd to
94c77f0
Compare
fpaul-1A
approved these changes
Dec 16, 2024
cpaulve-1A
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add persistence in
localStorageof code modifications in a training step.When the user refresh or come back on the training on which code modifications were made, we prompt a dialog to ask if he wants to keep the changes or discard them.
With this feature we think also to add a
ResetorDiscard changesbutton, it will be done in another PR, unless someone think it's a must inside this PR.