chore: reduce project.json duplication and split prepublish #2658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit dcd6f8f.
☁️ Nx Cloud last updated this comment at |
github-actions
bot
added
project:@ama-sdk/client-angular
project:@ama-sdk/client-beacon
project:@ama-sdk/client-fetch
project:@ama-sdk/core
project:@ama-sdk/create
project:@ama-sdk/schematics
project:@ama-sdk/swagger-builder
project:@ama-terasu/cli
project:@ama-terasu/core
project:@ama-terasu/schematics
project:@o3r-training/showcase-sdk
project:@o3r-training/training-tools
project:@o3r/amaterasu-api-spec
project:@o3r/amaterasu-dodo
project:@o3r/amaterasu-otter
project:@o3r/amaterasu-sdk
project:@o3r/analytics
project:@o3r/apis-manager
project:@o3r/application
project:@o3r/artifactory-tools
project:@o3r/azure-tools
project:@o3r/build-helpers
project:@o3r/chrome-devtools
project:@o3r/components
project:@o3r/configuration
project:@o3r/core
project:@o3r/create
project:@o3r/design
project:@o3r/dev-tools
labels
kpanot
force-pushed
the
chore/nx-alignment
branch
2 times, most recently
from
29ce3df to
3e07761
Compare
matthieu-crouzet
previously approved these changes
Jan 7, 2025
kpanot
force-pushed
the
chore/nx-alignment
branch
3 times, most recently
from
7216b6a to
1f5f72d
Compare
fpaul-1A
reviewed
Jan 7, 2025
kpanot
force-pushed
the
chore/nx-alignment
branch
from
1f5f72d to
6c50eb6
Compare
fpaul-1A
reviewed
Jan 7, 2025
| @@ -16,15 +16,14 @@ | |||
| "build:tools": "yarn nx run-many --target=build --projects=eslint-plugin,workspace", | |||
| "build:lint": "yarn nx run-many --target=build --projects=eslint-plugin", | |||
| "build:swagger-gen": "yarn nx run-many --target=build-swagger", | |||
| "prepare:publish": "yarn prepare-publish \"$(yarn workspaces:list)\" --append dist", | |||
There was a problem hiding this comment.
The goal of this task was to fix #112, is this no longer applicable?
There was a problem hiding this comment.
It is still valid on Nx 19 (4s per prepare-publish task) but it is greatly reduced in Nx 20 (< 200ms).
kpanot
force-pushed
the
chore/nx-alignment
branch
5 times, most recently
from
deddd46 to
14044a2
Compare
fpaul-1A
reviewed
Jan 10, 2025
chore: split npm prepublish task
kpanot
force-pushed
the
chore/nx-alignment
branch
from
14044a2 to
dcd6f8f
Compare
fpaul-1A
approved these changes
Jan 13, 2025
cpaulve-1A
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
chore: reduce project.json duplication
chore: split npm prepublish task
Related issues
- No issue associated -