feat(dpf-18714): inNextMinutes operator

[vscaiceanu-1a]

Proposed change

Computing the input facts takes:

• 3.7748750001192093 ms for 1k rules
• 38.763249998912215 ms for 10k rules

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 227f851. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 9 targets

• nx run-many --target=test-int --parallel 2 --output-style=stream
• nx run-many --target=build --projects=eslint-plugin,dev-tools --parallel 3
• nx run-many --target=publish --parallel 3 --nx-bail --access=public --userconfig .verdaccio/conf/.npmrc-logged --tag=latest --@o3r:registry=http://127.0.0.1:4873 --@ama-sdk:registry=http://127.0.0.1:4873 --@ama-terasu:registry=http://127.0.0.1:4873
• nx affected --target=test --parallel 2 --cacheDirectory=D:\a\otter\otter/.cache/jest --base=remotes/origin/main --output-style=stream
• nx run-many --target=build --parallel 3
• nx affected --target=test --parallel 2 --cacheDirectory=/home/runner/work/otter/otter/.cache/jest --base=remotes/origin/main --output-style=stream
• nx run ama-sdk-generator-sdk:build-swagger
• nx affected --target=lint --parallel 3 --base=remotes/origin/main --configuration ci
• nx run-many --target=build-swagger --parallel 3

---

Sent with 💌 from NxCloud.

[vscaiceanu-1a]

Missing:

• JSON Schema update
• Documentation
• (metadata extraction)

@kpanot which JSON Schema are you referring to? The ruleset one hasn't been modified in this PR.

[kpanot]

I am not sure to understand the purpose of this part :S.
Why do you need it as you already have the list of facts available for the ruleset?

[vscaiceanu-1a]

The goal is to compute the list of input facts and no longer take into account the value of the inputFacts coming from the CMS.
We have even removed them from the showcase app ruleset https://github.com/AmadeusITGroup/otter/pull/835/files#diff-1c83c4284e0d72e53c44790c5bdd50daedb84c30b8e703c4e0552ecf2ab870ae

[kpanot]

I see, then the field should be flagged as deprecated in the JSON schema.
The function may needs also a better name, comments ans proper input typings

[vscaiceanu-1a]

Concerning the types for the input, we support nested rules and the method will iterate on many types of Objects or Arrays.

Here's an example of a nested rule:

        {
          'id': '6e8t54h6s4e-6erth46sre8th4-d46t8s13t5j2',
          'name': 'the second rule',
          'inputRuntimeFacts': ['UI_FACT_2'],
          'inputFacts': ['cart'],
          'outputRuntimeFacts': [],
          'rootElement': {
            'elementType': 'RULE_BLOCK',
            'blockType': 'IF_ELSE',
            'condition': {
              'any': [
                {
                  'lhs': {
                    'type': 'RUNTIME_FACT',
                    'value': 'UI_FACT_2'
                  },
                  'operator': 'equals',
                  'rhs': {
                    'type': 'LITERAL',
                    'value': false
                  }
                }
              ]
            },
            'successElements': [
              {
                'elementType': 'ACTION',
                'actionType': 'UPDATE_LOCALISATION',
                'key': 'my.loc.key2.success',
                'value': 'my.loc.value2.success'
              },
              {
                'elementType': 'ACTION',
                'actionType': 'UPDATE_LOCALISATION',
                'key': 'my.loc.key3.success',
                'value': 'my.loc.value3.success'
              },
              {
                'elementType': 'RULE_BLOCK',
                'blockType': 'IF_ELSE',
                'condition': {
                  'any': [
                    {
                      'lhs': {
                        'type': 'FACT',
                        'value': 'cart',
                        'path': '$.xmasHampers[0].hamperItems[1].id'
                      },
                      'operator': 'equals',
                      'rhs': {
                        'type': 'LITERAL',
                        'value': 'foieGras'
                      }
                    }
                  ]
                },
                'successElements': [
                  {
                    'elementType': 'ACTION',
                    'actionType': 'UPDATE_LOCALISATION',
                    'key': 'my.loc.key4.success',
                    'value': 'my.loc.value4.success'
                  }
                ],
                'failureElements': [
                  {
                    'elementType': 'ACTION',
                    'actionType': 'UPDATE_LOCALISATION',
                    'key': 'my.loc.key5.failure',
                    'value': 'my.loc.value5.failure'
                  }
                ]
              },
              {
                'elementType': 'ACTION',
                'actionType': 'UPDATE_LOCALISATION',
                'key': 'my.loc.key6.success',
                'value': 'my.loc.value6.success'
              }
            ],
            'failureElements': [
              {
                'elementType': 'ACTION',
                'actionType': 'SET_FACT',
                'fact': 'UI_FACT_2',
                'value': false
              }
            ]
          }
        }

The method will find the cart fact in a successElements array.

[kpanot]

currentObject should be properly typed.
(this function can also be a private field to not be redefined at each execution)

[kpanot]

: any should be avoid, how do you guaranty that property.name exists otherwise?

[kpanot]

Avoid : any

[fpaul-1A]

Suggested change

	if (!operatorFactValues) {
	throw new Error('No operatorFactValues. Unable to retrieve the current time.');
	}
	if (typeof operatorFactValues.o3rCurrentTime !== 'number') {
	throw new Error('o3rCurrentTime value is not a number');
	}
	const currentTimeValue = operatorFactValues.o3rCurrentTime;
	const now = new Date(currentTimeValue);
	const leftDate = new Date(leftDateInput);
	const targetDate = new Date(new Date(currentTimeValue).setMinutes(now.getMinutes() + +minutes));
	return leftDate >= now && leftDate > targetDate;
	return !dateInNextMinutes.evaluator(leftDateInput, minutes, operatorFactValues);

?