fix(loc-extractor): do not resolve libraries files (empty libraries) #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2ccfd2b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
matthieu-crouzet
force-pushed
the
fix/localization-extractor-duplicate-keys-bis
branch
3 times, most recently
from
0347b83 to
30a68e4
Compare
matthieu-crouzet
changed the title
kpanot
reviewed
Oct 19, 2023
packages/@o3r/localization/builders/helpers/localization.generator.ts
Outdated
Show resolved
Hide resolved
packages/@o3r/localization/builders/helpers/localization.generator.ts
Outdated
Show resolved
Hide resolved
packages/@o3r/localization/builders/helpers/localization.generator.ts
Outdated
Show resolved
Hide resolved
matthieu-crouzet
force-pushed
the
fix/localization-extractor-duplicate-keys-bis
branch
from
30a68e4 to
4216fba
Compare
fpaul-1A
reviewed
Oct 20, 2023
packages/@o3r/localization/builders/helpers/localization.generator.ts
Outdated
Show resolved
Hide resolved
fpaul-1A
reviewed
Oct 20, 2023
packages/@o3r/localization/builders/helpers/localization.generator.ts
Outdated
Show resolved
Hide resolved
matthieu-crouzet
force-pushed
the
fix/localization-extractor-duplicate-keys-bis
branch
2 times, most recently
from
02d70af to
c65378b
Compare
kpanot
previously approved these changes
Oct 23, 2023
fpaul-1A
previously approved these changes
Oct 23, 2023
matthieu-crouzet
force-pushed
the
fix/localization-extractor-duplicate-keys-bis
branch
from
c65378b to
81bdcf5
Compare
matthieu-crouzet
dismissed stale reviews from fpaul-1A and kpanot
via
2ccfd2b
matthieu-crouzet
force-pushed
the
fix/localization-extractor-duplicate-keys-bis
branch
from
81bdcf5 to
2ccfd2b
Compare
kpanot
approved these changes
Oct 27, 2023
fpaul-1A
reviewed
Oct 27, 2023
fpaul-1A
approved these changes
Oct 27, 2023
matthieu-crouzet
deleted the
fix/localization-extractor-duplicate-keys-bis
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Related issues