Skip to content

Commit

Permalink
lock_api: Add MappedArcMutexGuard to mirror MappedMutexGuard
Browse files Browse the repository at this point in the history
  • Loading branch information
dflemstr committed Jan 13, 2025
1 parent ca920b3 commit 412586c
Show file tree
Hide file tree
Showing 2 changed files with 155 additions and 0 deletions.
146 changes: 146 additions & 0 deletions lock_api/src/mutex.rs
Original file line number Diff line number Diff line change
Expand Up @@ -962,3 +962,149 @@ impl<'a, R: RawMutex + 'a, T: fmt::Display + ?Sized + 'a> fmt::Display

#[cfg(feature = "owning_ref")]
unsafe impl<'a, R: RawMutex + 'a, T: ?Sized + 'a> StableAddress for MappedMutexGuard<'a, R, T> {}

/// An RAII mutex guard returned by `ArcMutexGuard::map`, which can point to a
/// subfield of the protected data.
///
/// The main difference between `MappedArcMutexGuard` and `ArcMutexGuard` is that the
/// former doesn't support temporarily unlocking and re-locking, since that
/// could introduce soundness issues if the locked object is modified by another
/// thread.
#[cfg(feature = "arc_lock")]
#[clippy::has_significant_drop]
#[must_use = "if unused the Mutex will immediately unlock"]
pub struct MappedArcMutexGuard<R: RawMutex, T: ?Sized> {
raw: Arc<R>,
data: *mut T,
marker: PhantomData<T>,
}

#[cfg(feature = "arc_lock")]
unsafe impl<R: RawMutex + Sync, T: ?Sized + Sync> Sync for MappedArcMutexGuard<R, T> {}
#[cfg(feature = "arc_lock")]
unsafe impl<R: RawMutex, T: ?Sized + Send> Send for MappedArcMutexGuard<R, T> where
R::GuardMarker: Send
{
}

#[cfg(feature = "arc_lock")]
impl<R: RawMutex, T: ?Sized> MappedArcMutexGuard<R, T> {
/// Makes a new `MappedArcMutexGuard` for a component of the locked data.
///
/// This operation cannot fail as the `MappedArcMutexGuard` passed
/// in already locked the mutex.
///
/// This is an associated function that needs to be
/// used as `MappedArcMutexGuard::map(...)`. A method would interfere with methods of
/// the same name on the contents of the locked data.
#[inline]
pub fn map<U: ?Sized, F>(s: Self, f: F) -> MappedArcMutexGuard<R, U>
where
F: FnOnce(&mut T) -> &mut U,
{
let raw = Arc::clone(&s.raw);
let data = f(unsafe { &mut *s.data });
mem::forget(s);
MappedArcMutexGuard {
raw,
data,
marker: PhantomData,
}
}

/// Attempts to make a new `MappedArcMutexGuard` for a component of the
/// locked data. The original guard is returned if the closure returns `None`.
///
/// This operation cannot fail as the `MappedArcMutexGuard` passed
/// in already locked the mutex.
///
/// This is an associated function that needs to be
/// used as `MappedArcMutexGuard::try_map(...)`. A method would interfere with methods of
/// the same name on the contents of the locked data.
#[inline]
pub fn try_map<U: ?Sized, F>(s: Self, f: F) -> Result<MappedArcMutexGuard<R, U>, Self>
where
F: FnOnce(&mut T) -> Option<&mut U>,
{
let raw = Arc::clone(&s.raw);
let data = match f(unsafe { &mut *s.data }) {
Some(data) => data,
None => return Err(s),
};
mem::forget(s);
Ok(MappedArcMutexGuard {
raw,
data,
marker: PhantomData,
})
}
}

#[cfg(feature = "arc_lock")]
impl<R: RawMutexFair, T: ?Sized> MappedArcMutexGuard<R, T> {
/// Unlocks the mutex using a fair unlock protocol.
///
/// By default, mutexes are unfair and allow the current thread to re-lock
/// the mutex before another has the chance to acquire the lock, even if
/// that thread has been blocked on the mutex for a long time. This is the
/// default because it allows much higher throughput as it avoids forcing a
/// context switch on every mutex unlock. This can result in one thread
/// acquiring a mutex many more times than other threads.
///
/// However, in some cases it can be beneficial to ensure fairness by forcing
/// the lock to pass on to a waiting thread if there is one. This is done by
/// using this method instead of dropping the `MutexGuard` normally.
#[inline]
pub fn unlock_fair(s: Self) {
// Safety: A MutexGuard always holds the lock.
unsafe {
s.raw.unlock_fair();
}
mem::forget(s);
}
}

#[cfg(feature = "arc_lock")]
impl<R: RawMutex, T: ?Sized> Deref for MappedArcMutexGuard<R, T> {
type Target = T;
#[inline]
fn deref(&self) -> &T {
unsafe { &*self.data }
}
}

#[cfg(feature = "arc_lock")]
impl<R: RawMutex, T: ?Sized> DerefMut for MappedArcMutexGuard<R, T> {
#[inline]
fn deref_mut(&mut self) -> &mut T {
unsafe { &mut *self.data }
}
}

#[cfg(feature = "arc_lock")]
impl<R: RawMutex, T: ?Sized> Drop for MappedArcMutexGuard<R, T> {
#[inline]
fn drop(&mut self) {
// Safety: A MappedArcMutexGuard always holds the lock.
unsafe {
self.raw.unlock();
}
}
}

#[cfg(feature = "arc_lock")]
impl<R: RawMutex, T: fmt::Debug + ?Sized> fmt::Debug for MappedArcMutexGuard<R, T> {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
fmt::Debug::fmt(&**self, f)
}
}

#[cfg(feature = "arc_lock")]
impl<R: RawMutex, T: fmt::Display + ?Sized> fmt::Display for MappedArcMutexGuard<R, T> {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
(**self).fmt(f)
}
}

#[cfg(all(feature = "arc_lock", feature = "owning_ref"))]
unsafe impl<R: RawMutex, T: ?Sized> StableAddress for MappedArcMutexGuard<R, T> {}
9 changes: 9 additions & 0 deletions src/mutex.rs
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,15 @@ pub type MutexGuard<'a, T> = lock_api::MutexGuard<'a, RawMutex, T>;
/// thread.
pub type MappedMutexGuard<'a, T> = lock_api::MappedMutexGuard<'a, RawMutex, T>;

/// An RAII mutex guard returned by `ArcMutexGuard::map`, which can point to a
/// subfield of the protected data.
///
/// The main difference between `MappedArcMutexGuard` and `ArcMutexGuard` is that the
/// former doesn't support temporarily unlocking and re-locking, since that
/// could introduce soundness issues if the locked object is modified by another
/// thread.
pub type MappedArcMutexGuard<T> = lock_api::MappedArcMutexGuard<RawMutex, T>;

#[cfg(test)]
mod tests {
use crate::{Condvar, Mutex};
Expand Down

0 comments on commit 412586c

Please sign in to comment.