Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static Site Update: GitHub Pages #132

Merged
merged 14 commits into from
Oct 20, 2024

Conversation

yashksaini-coder
Copy link
Contributor

Fixes: #121

This pull request focuses on adding comprehensive documentation for the sneaky-package project, including contribution guidelines, installation instructions, usage examples, and an updated documentation site configuration.

Documentation Additions:

  • docs/contributing.md: Added detailed contribution guidelines, including steps for setting up the development environment, identifying issues, making changes, and submitting contributions.
  • docs/index.md: Created an index page to guide users through the documentation, including links to usage, installation, and contribution guidelines.
  • docs/installation.md: Provided a complete installation guide, including prerequisites, installation steps, verification, and troubleshooting tips.
  • docs/usage.md: Added usage instructions, including installation, basic usage, advanced features, and licensing information.

Documentation Site Configuration:

  • mkdocs.yml: Configured the documentation site with a theme, navigation structure, and Markdown extensions for better readability and usability.

This is before:-

sneaky-package-Before.webm

AND after the MKdocs:-

sneaky-package-After.webm

Hi @this-is-yaash @jindalpriyanshu101 I have build the Documentation site with Github Pages deployment using MKDocs. Review this PR and add proper labels to it.

@yashksaini-coder
Copy link
Contributor Author

@this-is-yaash can you review this PR, add proper labels to it.

@jindalpriyanshu101
Copy link
Collaborator

Hey @yashksaini-coder, its really impressive, but can't you use some minimalist kind of theme? as the current one feels a little bit over in terms of colors..

@yashksaini-coder
Copy link
Contributor Author

Hey @yashksaini-coder, its really impressive, but can't you use some minimalist kind of theme? as the current one feels a little bit over in terms of colors..

yes I agree with you I was looking for github-dark theme, but for testing purposes this once was the best I could find on internet

@yashksaini-coder
Copy link
Contributor Author

I will keep looking for the themes, and will share samples in the meantime @jindalpriyanshu101

@jindalpriyanshu101
Copy link
Collaborator

Well then, Everything looks good to me. However, changing theme to something blackish will be appreciated. Great Work tho. ;D

@jindalpriyanshu101 jindalpriyanshu101 added gssoc-ext Issues labelled only for GSSoC'24 Extended Edition level3 Issues that are hard to fix! hacktoberfest-accepted hacktoberfest 2024 labels Oct 19, 2024
Copy link
Collaborator

@this-is-yaash this-is-yaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is good.
We still have to update the home page (index.md)of the site.

Use your own approach to add contents in the home page and make a PR.
We'll get it merged!

@yashksaini-coder
Copy link
Contributor Author

Everything is good. We still have to update the home page (index.md)of the site.

Use your own approach to add contents in the home page and make a PR. We'll get it merged!

Understood, let me cook

Copy link
Collaborator

@ShashwatAgrawal20 ShashwatAgrawal20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

shipit

@yashksaini-coder
Copy link
Contributor Author

@this-is-yaash check my forked version link now I have added new docs & changes the theme to dark style

@this-is-yaash this-is-yaash merged commit 3b9e836 into AmateursLeague:main Oct 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext Issues labelled only for GSSoC'24 Extended Edition hacktoberfest-accepted hacktoberfest 2024 level3 Issues that are hard to fix!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating Static Site: GitHub Page
4 participants