Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(executors): don't wrap executors in a function to omit id arguments #1604

Merged
merged 1 commit into from
Dec 13, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions packages/npm/@amazeelabs/executors/src/client.tsx
Original file line number Diff line number Diff line change
@@ -58,11 +58,7 @@ export const useOperationExecutor: HookType = <
variables?: OperationVariables<TOperation>,
): Executor<TOperation> => {
const { executors } = useContext(ExecutorsContext);
const executor = findExecutor(executors, id, variables);
if (executor instanceof Function) {
return (vars?: OperationVariables<TOperation>) => executor(id, vars);
}
return executor;
return findExecutor(executors, id, variables);
};

export const useAllOperationExecutors: AllHookType = <
@@ -72,9 +68,7 @@ export const useAllOperationExecutors: AllHookType = <
variables?: OperationVariables<TOperation>,
) => {
const { executors } = useContext(ExecutorsContext);
return findExecutors(executors, id, variables).map((exec) =>
exec instanceof Function ? (vars) => exec(id, vars) : () => exec,
);
return findExecutors(executors, id, variables);
};

function DelayedOperation<T>({
6 changes: 3 additions & 3 deletions packages/npm/@amazeelabs/executors/src/lib.test.tsx
Original file line number Diff line number Diff line change
@@ -30,15 +30,15 @@ function Consumer({
}) {
const executor = useOperationExecutor(id as AnyOperationId, variables);
return (
<p>{typeof executor === 'function' ? executor(variables) : executor}</p>
<p>{typeof executor === 'function' ? executor(id, variables) : executor}</p>
);
}

function MultiConsumer({
id,
variables,
}: {
id: string;
id: AnyOperationId;
variables?: Record<string, any>;
}) {
const executors = useAllOperationExecutors(id as AnyOperationId, variables);
@@ -47,7 +47,7 @@ function MultiConsumer({
) : (
executors.map((executor, index) => (
<p key={index}>
{typeof executor === 'function' ? executor(variables) : executor}
{typeof executor === 'function' ? executor(id, variables) : executor}
</p>
))
);
9 changes: 2 additions & 7 deletions packages/npm/@amazeelabs/executors/src/server.tsx
Original file line number Diff line number Diff line change
@@ -56,10 +56,7 @@ export const useOperationExecutor: HookType = <
id: TOperation,
variables: OperationVariables<TOperation>,
): ExecutorFunction<TOperation> => {
const executor = findExecutor(getRegistry(), id, variables);
return executor instanceof Function
? (vars) => executor(id, vars)
: () => executor;
return findExecutor(getRegistry(), id, variables);
};

export const useAllOperationExecutors: AllHookType = <
@@ -68,9 +65,7 @@ export const useAllOperationExecutors: AllHookType = <
id: TOperation,
variables: OperationVariables<TOperation>,
): Array<ExecutorFunction<TOperation>> => {
return findExecutors(getRegistry(), id, variables).map((exec) =>
exec instanceof Function ? (vars) => exec(id, vars) : () => exec,
);
return findExecutors(getRegistry(), id, variables);
};

// eslint-disable-next-line @typescript-eslint/no-explicit-any
6 changes: 2 additions & 4 deletions packages/npm/@amazeelabs/executors/src/types.ts
Original file line number Diff line number Diff line change
@@ -14,15 +14,13 @@ type TestWithoutVariables = OperationId<
>;

export type ExecutorFunction<TOperation extends AnyOperationId> = (
id: TOperation,
variables: OperationVariables<TOperation>,
) => Promise<OperationResult<TOperation>>;

export type Executor<TOperation extends AnyOperationId> =
| OperationResult<TOperation>
| ((
id: TOperation,
variables: OperationVariables<TOperation>,
) => Promise<OperationResult<TOperation>>);
| ExecutorFunction<TOperation>;

type ExecutorWithVariables = Executor<TestWithVariables>;
type ExecutorWithoutVariables = Executor<TestWithoutVariables>;