chore: upgrade playwright and storybook #192
Conversation
pmelab
force-pushed
the
SLB-219-playwright-update
branch
2 times, most recently
from
8d076a6 to
2f58302
Compare
pmelab
changed the title
pmelab
force-pushed
the
SLB-219-playwright-update
branch
5 times, most recently
from
bedf578 to
b4f8387
Compare
| @@ -7,6 +7,7 @@ | |||
| "license": "ISC", | |||
| "type": "module", | |||
| "scripts": { | |||
| "prep": "playwright install chromium", | |||
There was a problem hiding this comment.
Hm. Previously there was a Playwright postinstall script which was downloading binaries during pnpm i. Looks like now it's gone.
Should we get rid of
silverback-template/.lagoon/Dockerfile
Line 11 in 3414576
There was a problem hiding this comment.
Ah, is that why playwright is not downloading browsers automatically any more?
There was a problem hiding this comment.
Well, it's a long story. Previously, when it was called playwright (not @playwright/test) we had this issue with automatic browsers download in all environments. I went with PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD=1 and controlled downloads. Then when I faced the missing binaries error on this repo, I thought it's the same issue and added the env var. I did not know that the postinstall hook is already gone.
There was a problem hiding this comment.
Ok, thank you for the clarification. Will clean this up then.
There was a problem hiding this comment.
Aha! Now it's clear.
Playwright v1.38.0
Breaking Changes: Playwright no longer downloads browsers automatically
Details: https://github.com/microsoft/playwright/releases/tag/v1.38.0
pmelab
force-pushed
the
SLB-219-playwright-update
branch
from
8808868 to
fdf02e6
Compare
necessary for storybook update
included in storybook 8
So each system has the right binaries.
pmelab
force-pushed
the
SLB-219-playwright-update
branch
from
fdf02e6 to
93e9acc
Compare
Description of changes
e2efor installing playwright.Motivation and context
Resolve issues where
e2etests could not find playwright browser binaries.How has this been tested?