SLB-435: redirects #297
Merged
SLB-435: redirects #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmelab
requested changes
Jul 5, 2024
apps/website/package.json
Outdated
| "vitest": "^1.1.1" | ||
| }, | ||
| "scripts": { | ||
| "test:static": "tsc --noEmit && eslint '**/*.{ts,tsx,js,jsx}' --ignore-path='./.gitignore'", | ||
| "full-rebuild": "pnpm clean && pnpm build:waku", | ||
| "start:drupal": "pnpm run --filter @custom/cms start", | ||
| "build:drupal": "CLOUDINARY_CLOUDNAME=test pnpm start-test start:drupal 8888 build:waku", | ||
| "build:waku": "waku build", | ||
| "build:waku": "waku build && pnpm redirects", | ||
| "redirects": "tsx ./src/build/redirects.ts --dir=dist/public", |
There was a problem hiding this comment.
ULTRA NITPICK! 🤓
Maybe call this build:redirects to make clear this is part of the build process.
There was a problem hiding this comment.
This is now renamed, I also think it makes more sense to have it called "build:redirects"
| @@ -44,19 +44,19 @@ display: | |||
| label: Statuscode | |||
| group_items: | |||
| 1: | |||
| title: '300 Multiple Choices' | |||
| title: '300 Mehrere Auswahlmöglichkeiten' | |||
There was a problem hiding this comment.
Drush export shenanigans? I would rather not include this in the diff. Lets keep it english by default.
There was a problem hiding this comment.
This should be removed now.
chindris
force-pushed
the
SLB-435-waku-redirects
branch
from
a1d4e91 to
4becfa4
Compare
pmelab
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.