Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue "Folder content is not encrypted #36" and Fixed Critical Security Bug #47

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ekam-g
Copy link

@ekam-g ekam-g commented Nov 18, 2023

Critical Security Bug

So first lets start with the Critical Security Bug. So the bug is that when you delete files you used

fs::remove_file("some file")

This data can be recovered, so I make a new functions delete_file and delete_folder. These functions write random bytes in the place of the file, thus making impossible to recover the file, thus solving the security bug. While this function is slower it is very good to use, especially with encryption in play.

Fix issue "Folder content is not encrypted #36"

The title is quite self explanatory but issue 36 is done and it works well!

Other Notes

While working on your projects I had some critiques, I recommend you type out your variable names instead of using abbreviations, it makes your code quite confusing to read.

Other that this I love your project and I hope it sees a bigger field! I wish you the best of luck!

@ekam-g
Copy link
Author

ekam-g commented Nov 21, 2023

Hello?

@AmineZouitine
Copy link
Owner

Hello?

I have a lot of work this week, I will review your contribution this weekend.

Thank you anyway for the work done.

@ekam-g
Copy link
Author

ekam-g commented Nov 25, 2023

Take your time bro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants