Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General improvements to CI #25

Merged
merged 2 commits into from
Oct 23, 2024
Merged

General improvements to CI #25

merged 2 commits into from
Oct 23, 2024

Conversation

Amjad50
Copy link
Owner

@Amjad50 Amjad50 commented Oct 23, 2024

  • Updated codecov-action to v4
  • Added clippy and fmt checks

PRs won't fail now when uploading to codecov

Signed-off-by: Amjad Alsharafi <[email protected]>
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.81%. Comparing base (db5be91) to head (dbec9f3).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
plastic_core/src/misc.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
- Coverage   81.86%   81.81%   -0.05%     
==========================================
  Files          37       37              
  Lines        5349     5352       +3     
==========================================
  Hits         4379     4379              
- Misses        970      973       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Amjad50 Amjad50 merged commit 6dca498 into master Oct 23, 2024
2 of 4 checks passed
@Amjad50 Amjad50 deleted the improve_ci branch October 23, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant