Fix: Add plastic.desktop file to release

[marcelarie]

This PR adds package/plastic.desktop to the release to ensure it's available as a source in the PKGBUILD, following the discussion in issue #31 about including the .desktop file and logo in the Arch packages.

CC: @orhun

[Amjad50]

I don't think this is where you want to edit (also there is a typo in desktop).

This adds it to the release artifact, which includes the Deb file which has the desktop inside it anyway.

From what I understand the arch pkgbuild file uses the source pushed in crates.io, and thus, we need to change Cargo.toml to include them.

Though I'm not sure on this, can you confirm @orhun ?

[marcelarie]

I don't think this is where you want to edit (also there is a typo in desktop).

Go it, it is the first time that I work with Arch packages, sorry for the noise. I wait for the reply of @orhun to see if he knows better and if not I find an alternative.

[marcelarie]

I did a test locally before and it worked, idk how because it had the typo. Now that is fixed, and I did another test with a testing release from my fork and it works.

You can see the app is available, and the icon moved, here:

[silverhadch]

Looks good. However dont forget the Manpage in the package.

[silverhadch]

I did a test locally before and it worked, idk how because it had the typo. Now that is fixed, and I did another test with a testing release from my fork and it works.

You can see the app is available, and the icon moved, here:

Try it in a VM please thats how i test my debian packages.

[orhun]

Adding the desktop file to the repo in #40 was enough for the Arch package. Adding it to the releases is optional :)

[Amjad50]

Adding the desktop file to the repo in #40 was enough for the Arch package. Adding it to the releases is optional :)

Alright, I guess then you just need to update the arch pkgbuild to install those files

[orhun]

yup

[Amjad50]

Alright, then no need to add it to the release package specifically.
These files are already part of the deb file.

I'll close this PR, but thanks for bringing this up and fixing the arch recipe.

The arch recipe uses the files from source directly, reference to the PR for Arch: https://gitlab.archlinux.org/archlinux/packaging/packages/plastic/-/merge_requests/1

[marcelarie]

Alright, then no need to add it to the release package specifically. These files are already part of the deb file.

I'll close this PR, but thanks for bringing this up and fixing the arch recipe.

The arch recipe uses the files from source directly, reference to the PR for Arch: https://gitlab.archlinux.org/archlinux/packaging/packages/plastic/-/merge_requests/1

Hi, I created the other PR that points to the source directly, but the files are not available in the release without these changes, as far as I know.

[Amjad50]

Using the release package as its doing here is a workaround, the solution is to release a new version of plastic, the issue is that the arch package uses v0.3.1 which doesn't have the new files

I'll release a new version, I thought I'll delay it to work on some features, but I'll do it now.

[marcelarie]

Got it! Thanks for the explanation, now its more clear.

[Amjad50]

Released 0.3.4, please use this as the source for the arch recipe, and you don't need to add the individual files as sources.

[marcelarie]

@Amjad50 I tried it with the new release and it works.