Skip to content
This repository has been archived by the owner on Sep 22, 2023. It is now read-only.

fix: fix errors in Java SDK group examples, make Java examples more concise #965

Merged
merged 1 commit into from
Sep 7, 2023
Merged

fix: fix errors in Java SDK group examples, make Java examples more concise #965

merged 1 commit into from
Sep 7, 2023

Conversation

justin-fiedler
Copy link
Collaborator

@justin-fiedler justin-fiedler commented Sep 7, 2023 •
edited
Loading

Description

AMP-84156

  • fix errors in Java SDK group examples
  • link to group examples in Java SDK repo
  • make Java examples more concise (remove try/catch on JSONObject creation)

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ MARKDOWN markdownlint 1 0 0.41s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@aws-amplify-us-east-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-965.d19s7xzcva2mw3.amplifyapp.com

Mercy811
Mercy811 approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@Mercy811 Mercy811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the link the demo.

Can we also update the code snippet here to remove try and catch to keep consistent?

@justin-fiedler justin-fiedler merged commit 69581c3 into main Sep 7, 2023
4 checks passed
@justin-fiedler justin-fiedler deleted the AMP-84156-fix-java-groups-example branch September 7, 2023 23:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Mercy811 Mercy811 Mercy811 approved these changes

@yuhao900914 yuhao900914 Awaiting requested review from yuhao900914

@markzegarelli markzegarelli Awaiting requested review from markzegarelli markzegarelli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justin-fiedler @Mercy811