-
Notifications
You must be signed in to change notification settings - Fork 10
feat(Page): Add support for an application layout #2263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
We make this equal to the padding for a predictable layout change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for an application layout to the Page component, enabling a new navigation pattern with a side menu alongside the page header, main content, and footer. The implementation uses CSS Grid to organize these elements in a structured layout suitable for applications rather than traditional websites.
Key Changes:
- Added
layout="application"prop to Page component to enable application-specific grid layout - Created reusable Layout and MenuWithItems components for application pages
- Introduced HomePage example demonstrating the application layout pattern
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react/src/Page/Page.tsx | Adds optional layout prop to Page component |
| packages/css/src/components/page/page.scss | Implements CSS Grid layout for application pages |
| packages-proprietary/tokens/src/components/ams/page.tokens.json | Adds wider max-width token for application layout |
| storybook/src/pages/applications/common/Layout.tsx | Creates shared layout component for application pages |
| storybook/src/pages/applications/common/MenuWithItems.tsx | Implements reusable menu with navigation items |
| storybook/src/pages/applications/HomePage/HomePage.tsx | Adds homepage example using application layout |
| storybook/src/components/Page/Page.stories.tsx | Adds WithSideMenu story demonstrating application layout |
| storybook/src/components/Page/Page.docs.mdx | Documents application layout usage |
| packages-proprietary/tokens/src/components/ams/page-header.tokens.json | Adjusts row-gap spacing in page header |
| packages-proprietary/tokens/src/components/ams/page-footer.tokens.json | Adjusts row-gap spacing in page footer |
| storybook/config/preview.tsx | Auto-applies application layout for application pages |
| packages/css/src/components/page/README.md | Updates documentation for application support |
| storybook/src/styles/docs.css | Removes unused CSS selector |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| # Application home page | ||
|
|
||
| TODO |
Copilot
AI
Oct 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation file contains only a TODO placeholder. This should be replaced with actual documentation explaining the purpose and usage of the application homepage.
| TODO | |
| The application home page serves as the main entry point for users. It provides an overview of the application's features and navigation to key sections. Typically, users will find quick access to recent activity, important notifications, and shortcuts to commonly used tools or resources. | |
| ## Usage | |
| - Use the home page to get a summary of your application's status and recent updates. | |
| - Navigate to other sections of the application using the provided links or menus. | |
| - Review any alerts or messages displayed on the home page to stay informed about important events. | |
| The layout and available features may vary depending on user roles and application configuration. |
Describe the pull request
What
Why
To offer a robust and consistent navigation approach in our applications.
How
Defines a CSS Grid on Page if it carries the relevant prop.
Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:
Additional notes