Skip to content

Conversation

@Evi-2003
Copy link
Member

@Evi-2003 Evi-2003 commented Oct 31, 2025

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

Adds a disallow list to some workflows to prevent running unnecessary tests ⚡🌱.

  1. Feature branch deploy workflow
  2. Test (Chromatic) workflow
  3. Lint-test workflow

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

  • Provide links to any related issues or discussions.
  • Add a link to the specific story in the feature branch deploy.
  • Mention any areas where additional review or feedback is needed.

@Evi-2003 Evi-2003 self-assigned this Oct 31, 2025
@Evi-2003 Evi-2003 marked this pull request as ready for review October 31, 2025 08:31
@Evi-2003 Evi-2003 requested a review from a team as a code owner October 31, 2025 08:31
@Evi-2003 Evi-2003 marked this pull request as draft October 31, 2025 08:32
@Evi-2003
Copy link
Member Author

Okay, confirmed that this approach works.

@github-actions github-actions bot temporarily deployed to demo-exclude-chromatic-test October 31, 2025 08:36 Destroyed
@Evi-2003
Copy link
Member Author

Evi-2003 commented Oct 31, 2025

Chromatic now runs, as i've removed .yml from the disallow list.

@Evi-2003 Evi-2003 marked this pull request as ready for review October 31, 2025 08:39
@github-actions github-actions bot temporarily deployed to demo-exclude-chromatic-test October 31, 2025 12:34 Destroyed
@VincentSmedinga
Copy link
Contributor

We want to require the ‘UI Tests’ action to succeed before merging, so if we skip that action for a PR we can’t (easily) merge it.

@VincentSmedinga VincentSmedinga deleted the DES-1497/exclude-chromatic-test branch November 5, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants