Skip to content

Conversation

@Evi-2003
Copy link
Member

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

Adds sorts at different places in the renderComponentVariants-function.
This makes sure Chromatic has the same snapshots to test.

Why

Docgen from Storybook does not always give the same order of props. We need to make sure of that.

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

  • Provide links to any related issues or discussions.
  • Add a link to the specific story in the feature branch deploy.
  • Mention any areas where additional review or feedback is needed.

@Evi-2003 Evi-2003 self-assigned this Oct 31, 2025
@Evi-2003 Evi-2003 requested a review from a team as a code owner October 31, 2025 13:17
@github-actions github-actions bot temporarily deployed to demo-consistent-render-output-tests October 31, 2025 13:25 Destroyed
@github-actions github-actions bot temporarily deployed to demo-consistent-render-output-tests October 31, 2025 13:32 Destroyed
@github-actions github-actions bot temporarily deployed to demo-consistent-render-output-tests October 31, 2025 13:40 Destroyed
@github-actions github-actions bot temporarily deployed to demo-consistent-render-output-tests October 31, 2025 13:47 Destroyed
@Evi-2003
Copy link
Member Author

Okay, the output is now the same every time!

@Evi-2003 Evi-2003 marked this pull request as draft November 5, 2025 13:18
@Evi-2003
Copy link
Member Author

Evi-2003 commented Nov 5, 2025

These changes will be combined in the refactor pull request, to prevent merge conflicts.

@Evi-2003 Evi-2003 closed this Nov 5, 2025
@Evi-2003 Evi-2003 deleted the chore/consistent-render-output-tests branch November 5, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants