Refactor VergunningenV2 documents endpoint to decos endpoint

Amsterdam · Feb 3, 2025 · d6aff49 · d6aff49
1 parent 216c922
commit d6aff49
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 18 deletions.
diff --git a/src/server/routing/bff-routes.ts b/src/server/routing/bff-routes.ts
@@ -31,10 +31,9 @@ export const BffEndpoints = {
     '/services/stadspas/transactions/:transactionsKeyEncrypted?',
   STADSPAS_BLOCK_PASS: '/services/stadspas/block/:transactionsKeyEncrypted',
 
-  // Vergunningen V2
-  VERGUNNINGENv2_DOCUMENTS_LIST: `/services/vergunningen/v2/documents`,
-  VERGUNNINGENv2_DOCUMENT_DOWNLOAD:
-    '/services/vergunningen/v2/documents/download',
+  // Decos
+  DECOS_DOCUMENTS_LIST: `/services/decos/documents`,
+  DECOS_DOCUMENT_DOWNLOAD: '/services/decos/documents/download',
 
   // Vergunningen / Koppel api
   VERGUNNINGEN_DOCUMENT_DOWNLOAD:

diff --git a/src/server/routing/router-protected.ts b/src/server/routing/router-protected.ts
@@ -34,7 +34,7 @@ import {
 import { attachDocumentDownloadRoute } from '../services/shared/document-download-route-handler';
 import { fetchErfpachtV2DossiersDetail } from '../services/simple-connect/erfpacht';
 import { fetchBBDocument } from '../services/toeristische-verhuur/toeristische-verhuur-powerbrowser-bb-vergunning';
-import { fetchVergunningDocumentsList } from '../services/vergunningen-v2/vergunningen-route-handlers';
+import { fetchDecosDocumentsList } from '../services/vergunningen-v2/vergunningen-route-handlers';
 import { fetchZorgnedJZDDocument } from '../services/wmo/wmo-route-handlers';
 import { fetchWpiDocument } from '../services/wpi/api-service';
 
@@ -156,15 +156,12 @@ router.get(
   }
 );
 
-// Vergunningen V2
-router.get(
-  BffEndpoints.VERGUNNINGENv2_DOCUMENTS_LIST,
-  fetchVergunningDocumentsList
-);
+// Decos (Vergunningen, Horeca, Toeristische verhuur, Parkeren)
+router.get(BffEndpoints.DECOS_DOCUMENTS_LIST, fetchDecosDocumentsList);
 
 attachDocumentDownloadRoute(
   router,
-  BffEndpoints.VERGUNNINGENv2_DOCUMENT_DOWNLOAD,
+  BffEndpoints.DECOS_DOCUMENT_DOWNLOAD,
   fetchDecosDocument
 );
 

diff --git a/src/server/services/decos/decos-service.ts b/src/server/services/decos/decos-service.ts
@@ -704,7 +704,7 @@ export function transformDecosZaakFrontend<T extends DecosZaakBase>(
     steps: [],
     // Adds an url with encrypted id to the BFF Detail page api for zaken.
     fetchDocumentsUrl: generateFullApiUrlBFF(
-      BffEndpoints.VERGUNNINGENv2_DOCUMENTS_LIST,
+      BffEndpoints.DECOS_DOCUMENTS_LIST,
       [{ id: idEncrypted }]
     ),
     link: {

diff --git a/src/server/services/vergunningen-v2/vergunning-route-handlers.test.ts b/src/server/services/vergunningen-v2/vergunning-route-handlers.test.ts
@@ -1,6 +1,6 @@
 import { describe, it, expect, vi, Mock } from 'vitest';
 
-import { fetchVergunningDocumentsList } from './vergunningen-route-handlers';
+import { fetchDecosDocumentsList } from './vergunningen-route-handlers';
 import {
   getAuthProfileAndToken,
   RequestMock,
@@ -58,7 +58,7 @@ describe('fetchVergunningDocumentsList', () => {
 
     const res = ResponseMock.new();
 
-    await fetchVergunningDocumentsList(
+    await fetchDecosDocumentsList(
       req as RequestWithQueryParams<{ id: string }>,
       res
     );
@@ -75,7 +75,7 @@ describe('fetchVergunningDocumentsList', () => {
 
     const res = ResponseMock.new();
 
-    await fetchVergunningDocumentsList(
+    await fetchDecosDocumentsList(
       req as RequestWithQueryParams<{ id: string }>,
       res
     );
@@ -99,7 +99,7 @@ describe('fetchVergunningDocumentsList', () => {
 
     const res = ResponseMock.new();
 
-    await fetchVergunningDocumentsList(
+    await fetchDecosDocumentsList(
       req as RequestWithQueryParams<{ id: string }>,
       res
     );

diff --git a/src/server/services/vergunningen-v2/vergunningen-route-handlers.ts b/src/server/services/vergunningen-v2/vergunningen-route-handlers.ts
@@ -10,7 +10,7 @@ import { fetchDecosDocumentList } from '../decos/decos-service';
 import { DecosZaakBase } from '../decos/decos-types';
 import { decryptEncryptedRouteParamAndValidateSessionID } from '../shared/decrypt-route-param';
 
-export async function fetchVergunningDocumentsList(
+export async function fetchDecosDocumentsList(
   req: RequestWithQueryParams<{ id: string }>,
   res: Response
 ) {

diff --git a/src/server/services/vergunningen-v2/vergunningen.ts b/src/server/services/vergunningen-v2/vergunningen.ts
@@ -77,7 +77,7 @@ function addEncryptedDocumentDownloadUrl(
   return {
     ...document,
     // Adds an url to the BFF api for document download which accepts an encrypted ID only
-    url: generateFullApiUrlBFF(BffEndpoints.VERGUNNINGENv2_DOCUMENT_DOWNLOAD, [
+    url: generateFullApiUrlBFF(BffEndpoints.DECOS_DOCUMENT_DOWNLOAD, [
       { id: documentIdEncrypted },
     ]),
   };