Mijn-9575-feature varen service + thema pagina #1736
+564
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g in decos service
TerryvanWalen
changed the title
TerryvanWalen
changed the title
timvanoostrom
requested changes
Jan 30, 2025
TerryvanWalen
force-pushed
the
MIJN-9575-varen-service
branch
from
448b069 to
e464673
Compare
* Changed some texts, updated mockserver. No longer filter out on expiry date * Mijn-9980-bug geblokkeerde passen worden eruit gefiltert wut tf (#1725) * Fix test * Reset mocks?! * improve the test somewhat, making it less dependant on our filter * made test specific to filtering out a pass * Removed redundant snapshot * Refactored functions to be more readable and flexible * added types moved some stuff around * Add warning that you cannot reverse a block * Added expiry to filter, not yet working * Changed condition to only filter out expired passes that are expired on the default expiry date * Added deploy to test script * Text change according to MIJN-9995 * MIJN-9980-Chore - Add feature toggle * Replace isDateAfter with isAfter from imported library --------- Co-authored-by: Tim van Oostrom <[email protected]>
* Changed some texts, updated mockserver. No longer filter out on expiry date * Mijn-9980-bug geblokkeerde passen worden eruit gefiltert wut tf (#1725) * Fix test * Reset mocks?! * improve the test somewhat, making it less dependant on our filter * made test specific to filtering out a pass * Removed redundant snapshot * Refactored functions to be more readable and flexible * added types moved some stuff around * Add warning that you cannot reverse a block * Added expiry to filter, not yet working * Changed condition to only filter out expired passes that are expired on the default expiry date * Added deploy to test script * Text change according to MIJN-9995 * MIJN-9980-Chore - Add feature toggle * Replace isDateAfter with isAfter from imported library * Added featuretoggle to backedn --------- Co-authored-by: Tim van Oostrom <[email protected]>
…theffingen-niet-onder-de-juiste-kopjes-getoond (#1740) * Corrected condition * Aligned table columns * update snapshot * Add safety railing to script, if checkout fails it hard resets your own branch :)
…1744) * MIJN-10017-Feature - Better release flow * MIJN-10018-Bug - additional check for contactmomenten * MIJN-10017-Feature - better release pipeline (flow) * Add branch
* MIJN-10018-Bug - Only run if the tag was created on main * Specify real main * Add message job * Conditionally checkout repo * Remove condition, not allowed in this context * Change conditions * Change message
* Output the SourceBranch # Conflicts: # azure-release-pipeline.yaml * Change syntax * Different syntax
* Output the SourceBranch # Conflicts: # azure-release-pipeline.yaml # Conflicts: # azure-release-pipeline.yaml * Change syntax * Different syntax * Specify a stricter tag match * Remove conditions
timvanoostrom
requested changes
Jan 31, 2025
Comment on lines
+32
to
+33
| {!!buttonItems && | ||
| buttonItems.map(({ to, title }) => ( |
There was a problem hiding this comment.
Volgens mij kun je ook dit doen toch?
Suggested change
| {!!buttonItems && | |
| buttonItems.map(({ to, title }) => ( | |
| {buttonItems?.map(({ to, title }) => ( |
| title={title} | ||
| zaken={varenVergunningen.filter(filter).sort(sort)} | ||
| displayProps={displayProps} | ||
| textNoContent={`U heeft geen ${title.toLowerCase()}`} |
There was a problem hiding this comment.
Deze kun je weglaten. De standaard text is hetzelfde.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Varen service en thema pagina eerste werkende versie