MIJN-10018-Bug - Change notation #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TerryvanWalen
pushed a commit
that referenced
this pull request
Jan 31, 2025
TerryvanWalen
added a commit
that referenced
this pull request
Feb 3, 2025
* Remove unnecessary options parameter from transform function * Refactor decisionTranslations to function applied in transformFields * Fix return type of fetchDecosWorkflowDates. Record value can be undefined * Force consistent caseType from the calling service instead of defining in decos service * Lintfix * Remove non KVK Varenmock data * Type DecosZaakTransformer.title to force consistent title * Set default decision transformfield value * Varen initial thema service and thema page * Fix mailaddress in decosZaakTransformer varenRegistratieReder * Reorder varen frontend order * Surround decos filter query param in single quotes * fix show varen thema when reder is not available * Select all transform keys in decosZaakTransformer for decos call * fix type issues frontend * Surround decos filter in single quotes in test * Use newer fetchDocumentsUrl in VarenVergunningFrontend over fetchUrl * Rename varen boat to vessel * Remove todo about featureToggle from Varen * Extract GridDetails for gegevens aanvrager to own component * findings from FAT (#1734) * Move GridDetails component to own component file * Improve grid finetuning for Datalist (#1742) * Improve grid finetuning for Datalist * Use only one wrapped row * Remove unnecessary grid-auto-flow * Less code for same thing * Type, naming and lint changes * Rename varen files and move config config from thema to config file * Extract transformVergunningFrontendV2 to abstract decos transformDecosZaakFrontend * MIJN-9980-BUG/geblokkeerde-passen-worden-eruit-gefiltert (#1724) * Changed some texts, updated mockserver. No longer filter out on expiry date * Mijn-9980-bug geblokkeerde passen worden eruit gefiltert wut tf (#1725) * Fix test * Reset mocks?! * improve the test somewhat, making it less dependant on our filter * made test specific to filtering out a pass * Removed redundant snapshot * Refactored functions to be more readable and flexible * added types moved some stuff around * Add warning that you cannot reverse a block * Added expiry to filter, not yet working * Changed condition to only filter out expired passes that are expired on the default expiry date * Added deploy to test script * Text change according to MIJN-9995 * MIJN-9980-Chore - Add feature toggle * Replace isDateAfter with isAfter from imported library --------- Co-authored-by: Tim van Oostrom <[email protected]> * MIJN-9980-BUG/geblokkeerde-passen-worden-eruit-gefiltert (#1739) * Changed some texts, updated mockserver. No longer filter out on expiry date * Mijn-9980-bug geblokkeerde passen worden eruit gefiltert wut tf (#1725) * Fix test * Reset mocks?! * improve the test somewhat, making it less dependant on our filter * made test specific to filtering out a pass * Removed redundant snapshot * Refactored functions to be more readable and flexible * added types moved some stuff around * Add warning that you cannot reverse a block * Added expiry to filter, not yet working * Changed condition to only filter out expired passes that are expired on the default expiry date * Added deploy to test script * Text change according to MIJN-9995 * MIJN-9980-Chore - Add feature toggle * Replace isDateAfter with isAfter from imported library * Added featuretoggle to backedn --------- Co-authored-by: Tim van Oostrom <[email protected]> * MIJN-9745-BUG/onder-thema-parkeren-worden-de-decos-vergunningen-en-ontheffingen-niet-onder-de-juiste-kopjes-getoond (#1740) * Corrected condition * Aligned table columns * update snapshot * Add safety railing to script, if checkout fails it hard resets your own branch :) * update wrong status code cache clear condition (#1743) * Mijn-10017-Bug-MIJN-10018-Bug - better release pipeline and prod bug (#1744) * MIJN-10017-Feature - Better release flow * MIJN-10018-Bug - additional check for contactmomenten * MIJN-10017-Feature - better release pipeline (flow) * Add branch * Mijn-10018-bug pipeline release trigger (#1747) * MIJN-10018-Bug - Only run if the tag was created on main * Specify real main * Add message job * Conditionally checkout repo * Remove condition, not allowed in this context * Change conditions * Change message * MIJN-10018-Bug - Output the SourceBranch (#1748) * Output the SourceBranch # Conflicts: # azure-release-pipeline.yaml * Change syntax * Different syntax * Mijn-10018-bug pipeline trigger (#1749) * Output the SourceBranch # Conflicts: # azure-release-pipeline.yaml # Conflicts: # azure-release-pipeline.yaml * Change syntax * Different syntax * Specify a stricter tag match * Remove conditions * Change notation (#1750) * Simplify decos parameter types * Delete GridDetails component * Revert accidental change in incorrect file * Revert "Simplify decos parameter types" This reverts commit 30dcb12. * Replace ThemaPagina buttonItems with pageContentSecondary * Set thema configs as const and remove export from non-exported types/values * Filter gegevensAanvrager on content * Improve naming in Varen * Rename vergunning in transformDecosZaakFrontend to zaak * Refactor VergunningenV2 documents endpoint to decos endpoint * Remove unnecessary todos * Revert Afis fix from commit 0d73366 * Remove unnecessary field and unnecessary empty check in varen --------- Co-authored-by: Anouk <[email protected]> Co-authored-by: Tim van Oostrom <[email protected]> Co-authored-by: Roan Paulus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.