Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publication tables #13

Merged
merged 17 commits into from
Jul 15, 2024
Merged

Publication tables #13

merged 17 commits into from
Jul 15, 2024

Conversation

manilde
Copy link
Collaborator

@manilde manilde commented Jun 24, 2024

No description provided.

@manilde manilde requested a review from TerryvanWalen July 10, 2024 12:35
Copy link
Contributor

@TerryvanWalen TerryvanWalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great. There are some superfluous comments, I think you have to run the linter over it once more (spacing mostly) and for an outsider like me there are quite a lot of abbreviations that make the code hard to read. I take it that most abbreviations make sense if you are a data scientist and writing things out will not be practical but something to look into if you want

src/publicatie_tabellen/migrations/0002_db_functions.py Outdated Show resolved Hide resolved
tests/test_publicatie_tabellen/test_publish_observation.py Outdated Show resolved Hide resolved
tests/test_publicatie_tabellen/test_publish_observation.py Outdated Show resolved Hide resolved
tests/test_publicatie_tabellen/test_publish_statistic.py Outdated Show resolved Hide resolved
src/publicatie_tabellen/publish_observation.py Outdated Show resolved Hide resolved
src/publicatie_tabellen/publish_observation.py Outdated Show resolved Hide resolved
src/publicatie_tabellen/publish_observation.py Outdated Show resolved Hide resolved
src/publicatie_tabellen/publish_statistic.py Outdated Show resolved Hide resolved
@manilde manilde merged commit d4a68a1 into main Jul 15, 2024
2 checks passed
@manilde manilde deleted the publication_tables branch July 15, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants