Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/publication models #9

Merged
merged 10 commits into from
Dec 19, 2023
Merged

Feature/publication models #9

merged 10 commits into from
Dec 19, 2023

Conversation

manilde
Copy link
Collaborator

@manilde manilde commented Dec 15, 2023

-changes views and functions into separate app publicatie_tabellen
-removed db table names so django will add app name to table

Copy link

@thomasbrockmeier-ams thomasbrockmeier-ams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like mostly stuff being moved around, like you mentioned, so that should be good. Just wanted to confirm that it is indeed fine to retroactively alter the migration files.

@@ -1,4 +1,4 @@
# Generated by Django 4.1.7 on 2023-06-20 13:39
# Generated by Django 4.1.13 on 2023-12-15 11:46

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to double check, because I think we discussed this for another PR already: it is safe in this case to retroactively alter migrations, because this application/database is not in production, right?

Copy link
Collaborator Author

@manilde manilde Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes! still in development so now we can still make the migrations cleaner :-) So removed the db-views and switched to django-models.

manilde and others added 3 commits December 18, 2023 17:06
remove fixtures from import
renamed sd type 27 gebied
@Robkromwijk Robkromwijk merged commit 470fd0b into main Dec 19, 2023
3 checks passed
@Robkromwijk Robkromwijk deleted the feature/publication_models branch December 21, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants