Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registration page does not close if there are errors #24

Merged
merged 1 commit into from
Oct 9, 2016

Conversation

apoorv9990
Copy link
Contributor

No description provided.

@Ana06
Copy link
Owner

Ana06 commented Oct 9, 2016

Issue #13 doesn't mean that. When you sign in if you write your email wrong, when you click sign in, both the email and password are deleted and you have to write both things again. So, I think it will be better to keep at least the email (I am hesitant about the password as the user can not see what we really wrote).

However, I think that your change is great. When the sign up fails because the email is already in the database it could make sense to go back as the user should sign in and not sign up if his email is in hte database. But without redirecting we allow the user to check if his email is correct before, so he is sure that he need to sign in.

@Ana06 Ana06 merged commit 12f3c23 into Ana06:master Oct 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants