Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Math.ceil float values before creating a BigInt #502

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Salgueirinho
Copy link

@Salgueirinho Salgueirinho commented Feb 12, 2025

Description

Fixes a bug when creating a BigInt from a float number.

Fixes #501

Type of change

  • 🔧 Bug fix
  • 💡 New feature
  • 🔩 Performance improvement
  • 📚 Docs

If the feature is substantial or introduces breaking changes without a discussion, its best to open an issue first.

Checklist

  • I commented my code
  • Added/modified unit tests
  • I made corresponding changes to the documentation

Additional Notes

Running pnpm install updated some dependencies

Copy link

changeset-bot bot commented Feb 12, 2025

⚠️ No Changeset found

Latest commit: f4bd620

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: calculateMinRefScriptFee throws error when creating BigInt from a float value
1 participant