Update APY calculation to match webapp #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #67
After May 1st APY update the APY returned by the webapp became different than the APY returned by this package.
The APY calculation on the webapp was updated to return the new APY post dynamic APY update:
Anchor-Protocol/anchor-web-app#353
However, this package retained the old calculation.
This PR is attempting to make identical calculations to webapp.
It is suboptimal because it uses two queries (
queryOverseerEpochStateandqueryOverseerConfig) if the team deems it acceptable to create a new query that combines these queries together (likequeryOverseerEpochStateAndConfig) then I can also add this change. For now I am leaving as is for simple readability of the PR.