Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added meson build files and manifests for dlls. #167

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hanetzer
Copy link
Contributor

Works, builds both native linux and cross-compiles mingw-w64 variants.
Need to work out copying appropriate dlls into the mkxp runtime folder.

Follow up to #35

Signed-off-by: Marty Plummer [email protected]

@khkramer
Copy link

Could this potentially make a static build as well? I haven't been able to make a build with cmake sofar that doesn't force me to have like 20 dll's in my game folder.

@hanetzer
Copy link
Contributor Author

hanetzer commented Jul 18, 2017

@khkramer yes, but would require a static build of openal, which you can't easily do at the same time as a shared (dll) build. However, I've actually added the ability to use executable manifests, which allow you to basically subdir the dlls. In the current setup, you'd copy the dlls and runtime.manifest into a subdir next to the game executable.

Depending on how the libs are compiled you may need to adjust runtime.manifest (simple xml file, easy to understand).

@hanetzer
Copy link
Contributor Author

Actually, if you are going to merge this, do not do so until #168 is merged (if it is going to be merged).
I'll rebase this pr if/once that happens.

dependencies : [ ruby, sdl2, sigcxx ],
include_directories : incdirs,
target_type : 'static_library')

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does meson require to have its build files in every source directory, or is that just your convention?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its 'a' convention. not necessarily mine but its been the best way I've found to go about it for now.

Works, builds both native linux and cross-compiles mingw-w64 variants.
Need to work out copying appropriate dlls into the mkxp runtime folder.

Signed-off-by: Marty Plummer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants