-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert nil int/float arguments to 0 #227
base: master
Are you sure you want to change the base?
Conversation
I have to admit I'm not a huge fan of mkxp's As you can see it doesn't care about The RGSS peculiarity you've found and I didn't know about is that the BGM/BGS position argument can both be A preferable fix would be adding a mruby-like |
@cremno that makes sense. I'm not that familiar with ruby to begin with. But modelling the real constraints would avoid the problem of people targeting mkxp's implementation and then not running on real RPG maker runtime. |
Some games pass nil as bgs/bgm play pos arg :/
40e3caf
to
226b59c
Compare
Fixed formatting. |
To re-phrase my comment above: While your PR improves compatibility with the original implementation, it also introduces incompatibilities at the same time. Something like Btw. I've looked at the relevant |
Because this isn't proper fix. This PR won't be merged I guess? I'm aware of this converting all nils to 0 implicitly. I could alternatively add support for ! syntax in |
Another option would be to give rb_get_args a "type error" handler |
My comments are simply code review. Only @Ancurio got all the relevant powers. Maybe he doesn't like |
Sorry, I'll be getting around to this in a couple weeks. Thanks cremno for the pointers on |
Some games pass nil as bgs/bgm play pos arg :/