Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show number of search results in window title #1946

Merged
merged 3 commits into from
Jan 13, 2022

Conversation

timbze
Copy link
Contributor

@timbze timbze commented Nov 13, 2021

Needs 1 new string

Relates to #186

But might be in same state as #1938 that might be useless after #611 is implemented

The "(2 results)" in title is the change in this PR
Screenshot from 2021-11-13 11-09-43

@tuomas2 tuomas2 added the 4.1 label Nov 13, 2021
@agrogers
Copy link
Contributor

agrogers commented Nov 14, 2021 via email

@timbze
Copy link
Contributor Author

timbze commented Nov 14, 2021

I like it. What happens if it hits the 1000 verse limit? Just shows 1000?

Yes it would just show 1000

@tuomas2 tuomas2 merged commit 1c39531 into develop Jan 13, 2022
@timbze timbze deleted the feature/show_number_of_results_in_search branch January 21, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants