Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with sync_command #16

Merged
merged 20 commits into from
Oct 12, 2023
Merged

Issue with sync_command #16

merged 20 commits into from
Oct 12, 2023

Conversation

VadymMelnychuk
Copy link
Contributor

@VadymMelnychuk VadymMelnychuk commented Jul 24, 2023

I discovered next issue
when my HomeAssistant start I see all modes related to my WaterHeater
machMode = [1,2,3]

in settings section this parameter has type 'Range'
However, after I call command startProgram the 'machMode' become like a fixed. Only value '1' allowed
It happens bcs startProgram also has parameter 'machMode' but with type fixed. So, when you sync fixed -> range you do the reset for ranges.

Also i exxtended sync_command with 'to_sync' parameter:

  • if to_sync==True -> will sync only mandatory parameters
  • if to_sync is list -> will sync only parameters that exists in to_sync list

+2 minor fixes.

  • if cannot find parameter - havee to just continue (not return)
  • improved virtual 'active' state for water heater

pyhon/appliance.py Outdated Show resolved Hide resolved
Copy link
Owner

@Andre0512 Andre0512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fine now, thanks 👍

@Andre0512 Andre0512 merged commit 6ae4048 into Andre0512:main Oct 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants