Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to parse quantity when scanning items and materials #225

Closed
LiuAnshan opened this issue Feb 19, 2022 · 3 comments
Closed

Failed to parse quantity when scanning items and materials #225

LiuAnshan opened this issue Feb 19, 2022 · 3 comments

Comments

@LiuAnshan
Copy link

LiuAnshan commented Feb 19, 2022

The only issue I found that seemed to mention this seemed specifically for 1.2.1 build so I'm creating this issue.

I tried a few times at different window resolutions and seemed to have the least amount of failures at 3200x1800 which is 16x9 aspect ratio.

I'm not sure where to find the first several lines of the stack trace. I suspect there isn't one since the scanner did not fail or crash.

It seems that the majority of the failures contain a either a 1 as the first digit or are single digit 1s. There was one 2, one 3, one 4 and one 8 as well.

I'm not sure if there are other screenshots that could be helpful, I just grabbed 4 of them.
Log:



Failed to parse quantity for DvalinsPlume


Failed to parse quantity for MoltenMoment


Failed to parse quantity for VajradaAmethystFragment


Failed to parse quantity for PhilosophiesOfTransience


Failed to parse quantity for CrownOfInsight


Failed to parse quantity for BorealWolfsNostalgia


Failed to parse quantity for ShacklesOfTheDandelionGladiator


Failed to parse quantity for MistVeiledGoldElixir


Failed to parse quantity for LungedStickleback


Failed to parse quantity for GoldenKoi


Failed to parse quantity for RustyKoi


Failed to parse quantity for BrownShirakodai


Failed to parse quantity for PurpleShirakodai


Failed to parse quantity for Pufferfish


PhilosophiesOfTransience_Quantity - Copy
ShacklesOfTheDandelionGladiator_Quantity
mora
Pufferfish_Quantity

@Cupcak3
Copy link
Collaborator

Cupcak3 commented Feb 20, 2022

Thanks for the report. Unfortunately the scanner isn't the best when it comes to parsing quantities when they're so close to the stars. Single digit quantities as well as digits like 1, 4, 7 can give it a hard time. That and mora scanning are both in need of optimizations.

There's no stack traces because they weren't crashes and we log those images. We also log them as errors so you can know that something failed to scan correctly when you go to upload the exported data to a site.

I will keep this issue open so that duplicate issues can be redirected to this one.

@Blonger
Copy link

Blonger commented Feb 25, 2022

I got thoose errors while scanning with 1920x1080 px resolution, i tried with 50 ms delay got slightly different errors but basically and mostly the same.

`Failed to parse quantity for ChaosCore

Failed to parse quantity for MistGrassWick

Failed to parse quantity for InspectorsSacrificialKnife

Failed to parse quantity for FossilizedBoneShard

Failed to parse quantity for CrystalPrism

Failed to parse quantity for ConcealedUnguis

Failed to parse quantity for TearsOfTheCalamitousGod

Failed to parse quantity for TheMeaningOfAeons

Failed to parse quantity for CleansingHeart

Failed to parse quantity for PerpetualHeart

Failed to parse quantity for PhilosophiesOfProsperity

Failed to parse quantity for GuideToTransience

Failed to parse quantity for JeweledBranchOfADistantSea

Failed to parse quantity for GoldenBranchOfADistantSea

Failed to parse quantity for MistVeiledMercuryElixir

Failed to parse quantity for MistVeiledPrimoElixir

Failed to parse quantity for DebrisOfDecarabiansCity

Failed to parse quantity for VenomspineFish

Failed to parse quantity for Snowstrider

Failed to parse quantity for RustyKoi

Failed to parse quantity for DivdaRay

`

@Cupcak3
Copy link
Collaborator

Cupcak3 commented Jul 23, 2022

Duplicate of #96

@Cupcak3 Cupcak3 marked this as a duplicate of #96 Jul 23, 2022
@Cupcak3 Cupcak3 closed this as completed Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants