Kotlin-7 #29
Open
Kotlin-7 #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motorro
reviewed
Sep 16, 2024
| @@ -30,6 +30,8 @@ class ErrorLogger<E : Throwable> { | |||
| println("Error at $date: ${error.message}") | |||
| } | |||
| } | |||
|
|
|||
| fun dump(): List<Pair<LocalDateTime, Throwable>> = errors | |||
There was a problem hiding this comment.
@crayfish1975 , не совсем верно. Должно быть:
fun dump(): List<Pair<LocalDateTime, E>>
|
Здравствуйте. Спасибо!
Понедельник, 16 сентября 2024, 11:28 +04:00 от Nikolai Kotchetkov ***@***.***>:
@motorro commented on this pull request.
----------------------------------------------------------------------
In src/main/kotlin/ru/kotlin/homework/network/NetworkLogger.kt :
> @@ -30,6 +30,8 @@ class ErrorLogger<E : Throwable> {
println("Error at $date: ${error.message}")
}
}
+
+ fun dump(): List<Pair<LocalDateTime, Throwable>> = errors
@crayfish1975 , не совсем верно. Должно быть:
fun dump(): List<Pair<LocalDateTime, E>>
—
Reply to this email directly, view it on GitHub , or unsubscribe .
You are receiving this because you were mentioned. Message ID: <Android-Developer-Basic/Kotlin-7/pull/29/review/2305914557 @ github . com>
С уважением,
Сергей Минеев
***@***.***
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Что я вообще наделал? Я не понял как я сделал это дз. Если это возможно, можно пожалуйста объяснить почему при добавлении приставки "private" к переменной errors во втором задании, исчезает ошибка (Type parameter E is declared as 'in' but occurs in 'invariant' position in type MutableList<Pair<LocalDateTime, E>>)?
И зачем вообще в определении переменной (val errors = mutableListOf<Pair<LocalDateTime, E>>()) нужен "E", если его можно заменить на "Throwable", и все будет работать, и даже без "private"?